hydrus icon indicating copy to clipboard operation
hydrus copied to clipboard

Update README.md

Open Krish-bhardwaj opened this issue 3 years ago • 15 comments

issue number #607

Checklist

  • [x] My branch is up-to-date with upstream/develop branch.
  • [x] Everything works and tested for Python 3.6.0 and above.

Current behaviour

less reference and some grammatical error in readme file

New expected behaviour

fixed issue

Change logs

can see my commit

Krish-bhardwaj avatar Jan 26 '22 10:01 Krish-bhardwaj

Hi maintainers , i am new to open source contribution , requested to merge my PR

Krish-bhardwaj avatar Jan 26 '22 10:01 Krish-bhardwaj

hydrus shall be alway lowercase

Mec-iS avatar Jan 27 '22 00:01 Mec-iS

please try to run the server in local and see if there is something useful you can add to the document, at this point there are only minor changes in this PR.

Mec-iS avatar Jan 27 '22 00:01 Mec-iS

Ok

Krish-bhardwaj avatar Jan 27 '22 04:01 Krish-bhardwaj

Hi @Mec-iS i have done some more changes in the doc please review it. Requested to merge the PR.

Krish-bhardwaj avatar Jan 29 '22 04:01 Krish-bhardwaj

Hi @Mec-iS why has this test failed ! can you explain me .

Krish-bhardwaj avatar Jan 29 '22 04:01 Krish-bhardwaj

you can see the full Travis log at https://app.travis-ci.com/github/HTTP-APIs/hydrus/jobs/557575062

nice try but it is still minor changes.

Conventions:

  • correct spell is "Hydra" for the framework
  • correct spell is "hydrus" for the server

Mec-iS avatar Jan 29 '22 05:01 Mec-iS

you can see the full Travis log at https://app.travis-ci.com/github/HTTP-APIs/hydrus/jobs/557575062

nice try but it is still minor changes.

Conventions:

  • correct spell is "Hydra" for the framework
  • correct spell is "hydrus" for the server

can u explain me this error i am not able to figure it out , i have just changed / added new reference

Krish-bhardwaj avatar Jan 29 '22 06:01 Krish-bhardwaj

Hi @Mec-iS i have updated the Doc/wiki/images they were not clear and the updated version is better , requested to merge this pr or suggest some more changes

Krish-bhardwaj avatar Jan 29 '22 18:01 Krish-bhardwaj

Conventions: correct spell is "Hydra" for the framework correct spell is "hydrus" for the server

this is still not implemented.

Also you have to rebase this PR to the develop branch

Mec-iS avatar Jan 29 '22 19:01 Mec-iS

Conventions: correct spell is "Hydra" for the framework correct spell is "hydrus" for the server

this is still not implemented.

Also you have to rebase this PR to the develop branch

ok ill look into it

Krish-bhardwaj avatar Jan 29 '22 19:01 Krish-bhardwaj

Conventions: correct spell is "Hydra" for the framework correct spell is "hydrus" for the server

this is still not implemented.

Also you have to rebase this PR to the develop branch

my branch is already on develop image

Krish-bhardwaj avatar Jan 29 '22 19:01 Krish-bhardwaj

Also you have to rebase this PR to the develop branch

my branch is already on develop image

yes but your develop is not up to date with the remote one, so you have to pull or rebase. You need to be familiar with git and Github.

Mec-iS avatar Jan 29 '22 19:01 Mec-iS

Also you have to rebase this PR to the develop branch

my branch is already on develop image

yes but your develop is not up to date with the remote one, so you have to pull or rebase. You need to be familiar with git and Github.

now can you verify is my branch up to date ! , i will correct hydra and hydrus typo

Krish-bhardwaj avatar Jan 29 '22 19:01 Krish-bhardwaj

hi @Mec-iS i have done some more contribution , i have one doubt when we run help(hydrus) it is not showing all the comments why ? image

Krish-bhardwaj avatar Feb 04 '22 06:02 Krish-bhardwaj