hydra-python-core icon indicating copy to clipboard operation
hydra-python-core copied to clipboard

Added collection to response context

Open raoashish10 opened this issue 5 years ago • 2 comments

Regarding #57

Checklist

  • [x] My branch is up-to-date with upstream/develop branch.
  • [x] Everything works and tested for Python 3.5.2 and above.

Description

So I have added the code and adds the Collection keyword in the context of the response but I am not sure about the code ie. I am not sure if the position of the code is apt and if this was the fix that was needed. So please guide me and let me know if there are mistakes.

Change logs

Added

  • Added Collection keyword in the response context generated.

raoashish10 avatar Oct 14 '20 11:10 raoashish10

@farazkhanfk7 do you think this is still useful?

Mec-iS avatar May 31 '21 16:05 Mec-iS

yes we can still add this. But I think it should be collections. Also this is only a single line change but we'll also have to update tests and add these changes in Context class of doc_writer.py.

farazkhanfk7 avatar Jun 01 '21 16:06 farazkhanfk7