digitransit-ui icon indicating copy to clipboard operation
digitransit-ui copied to clipboard

AB#340 Fix travel companion repeating card

Open sharhio opened this issue 2 months ago • 0 comments

Proposed Changes

  • getting the legs of interest now uses the actual current time to ensure the legs are always relevant and that there is no time jumps back and forth in the time that is supposed to be current.
  • getLegType now uses the actual current time to check if the journey has started (affects the glitchy card showing up briefly)
  • The nextLeg is also reverted to the previous value when the animation is in motion to keep the view consistent.
  • legChange value is taken into account when determining whether to show previous or current leg info to ensure that there is no rendering glitch while the cardChanging variable with timer is being set.

Pull Request Check List

  • A reasonable set of unit tests is included
  • Console does not show new warnings/errors
  • Changes are documented or they are self explanatory
  • This pull request does not have any merge conflicts
  • All existing tests pass in CI build

Review

  • Read and verify the code changes
  • Test the functionality by running the UI locally with all popular browsers available in your platform
  • Check that the implementation matches the design, when such one is defined in an issue in Azure Boards
  • Merge the pull request

sharhio avatar Nov 26 '25 10:11 sharhio