hsf.github.io icon indicating copy to clipboard operation
hsf.github.io copied to clipboard

Add prettier pre-commit hook

Open klieret opened this issue 2 years ago • 1 comments

This hook provides standardized formatting for a variety of files, including markdown (where it mostly wraps text) and yaml (I've removed HTML and CSS because it struggled with some custom elements there).

I'd say we want at least some of this, but this also now changes almost every single file, meaning that hanging PRs will most likely yield merge conflicts (that can be resolved by applying this hook there as well).

I'm opening this PR to discuss about this ;)

EDIT: Something still seems to go wrong when applying this in CI

klieret avatar Aug 13 '23 11:08 klieret

Hello @klieret, is this big MR still relevant (especially that we are going to revamp the site) or better close at this point? Advance thanks.

eduardo-rodrigues avatar Jun 26 '24 08:06 eduardo-rodrigues

Hello @graeme-a-stewart, @hegner, @jouvin, I would be tempted to close this PR at this point. It is massive and with ideas of "upgrading" the site, it seems less relevant.

eduardo-rodrigues avatar Sep 04 '24 11:09 eduardo-rodrigues

Hi @eduardo-rodrigues - I would agree, given the medium term plan to change website technology, a large formatting PR isn't so useful, so let's close this one.

graeme-a-stewart avatar Sep 09 '24 08:09 graeme-a-stewart