hsf.github.io icon indicating copy to clipboard operation
hsf.github.io copied to clipboard

Absolute paths for link checker and baseURL

Open klieret opened this issue 2 years ago • 2 comments

In reference to #1046

klieret avatar Feb 14 '23 16:02 klieret

Hello @klieret, cc @graeme-a-stewart and @hegner for website enhancements. I see this long-standing PR. It's rather short. Do you intend to finalise or else we close at this point?

eduardo-rodrigues avatar May 03 '24 08:05 eduardo-rodrigues

Hello @klieret, what is the status here? Let me also ping @graeme-a-stewart and @hegner since they are thinking about the new revamped site.

eduardo-rodrigues avatar Jun 26 '24 08:06 eduardo-rodrigues

Is this PR still relevant? I have the feeling that yes and it would be a good idea not to hardcode the host name of the web site? If yes, why we don't merge this PR is @klieret is not available to follow it up?

jouvin avatar Sep 04 '24 10:09 jouvin

Probably. I'm no expert but the changes seem small eough that somebody can review?

eduardo-rodrigues avatar Sep 04 '24 11:09 eduardo-rodrigues

I can take a look, but I would say this wants a rebase first!

graeme-a-stewart avatar Sep 04 '24 14:09 graeme-a-stewart

OK, this all looks good to me. Killian had set it to link check the whole site, but that took about an hour and we used to get badly burned by false positives when that was done on PRs. So I have reverted to the check of changed pages only. (It would be good to also have a workflow that triggers a whole site check, but that shouldn't be the normal workflow for PRs.)

graeme-a-stewart avatar Sep 08 '24 14:09 graeme-a-stewart