matchpy icon indicating copy to clipboard operation
matchpy copied to clipboard

Usage of type unions

Open Upabjojr opened this issue 7 years ago • 1 comments

I have translated some parts of MatchPy into C++. I am finding difficulties implementing the type Union[TLeft, TRight]. I could use C++17 and variant<TLeft, TRight>, but this would break compatibility with older compilers.

I have translated parts of BipartiteGraph into C++ and I have temporarily used the template TEdgeValue only: https://github.com/symengine/symengine/blob/9cb6da759fb95e2ffece407e0cf2bad136a3933b/matchpygen/bipartite.h#L29

Could the dictionary _graph be split into _graph_left and _graph_right to keep type consistency without type unions?

Upabjojr avatar Nov 26 '18 16:11 Upabjojr

Looking at the code, I would say yes.

hbarthels avatar Nov 28 '18 15:11 hbarthels