feat #3763: add April Fool's Day version category
feat #3763
add April Fool's Day version category
缺失了 2.0 愚人节版本,因为 client json 所标注的时间是错误的(这些 client json 来自 Minecraft Wiki),或许应该单独做判断?
而且版本 id 后缀包含类型,然后跳转到了错误的地址(https://zh.minecraft.wiki/w/2.0_blue?variant=zh-cn),或许这个也应该单独做判断?
Firstly, I'm concerned about the UI overflow that might result from too many options above. Check the image.
Adding a separate panel for the search box would solve it.
Image
Is that acceptable?
Secondly, the time displayed on this page changes depending on the user's current time zone, which in some different time zones may result in this category not presenting results at all. I think you should use other methods to achieve the same effect and make sure that the results are displayed as they should be even in various time zones.
Most April Fools' versions were released on 1 April UTC. However, there exists an April Fools' Day version released on 31 March UTC, which is Java_Edition_1.RV-Pre1
Maybe use UTC time for judgement and special judgement for Java_Edition_1.RV-Pre1?
我觉得可以直接硬编这些已有的愚人节版本,然后再判断 4 月 1 日的版本(将这个判断视作硬编前的特殊判断)
我觉得可以直接硬编这些已有的愚人节版本,然后再判断 4 月 1 日的版本(将这个判断视作硬编前的特殊判断)
Hardcoding would result in the need to modify the source code for each release of April Fool's Day version. Since 2013, there has only been one April Fool's Day version released on 31 March instead of 1 April. Perhaps hardcoding only those releases that were not released on 1 April would reduce the workload.
Adding a separate panel for the search box would solve it.
Is that acceptable?
Personally, I think that for the search and refresh icons, you can just keep the icons themselves. The acceptability of this depends on the opinion of the maintainers.
Most April Fools' versions were released on 1 April UTC. However, there exists an April Fools' Day version released on 31 March UTC, which is Java_Edition_1.RV-Pre1
Maybe use UTC time for judgement and special judgement for Java_Edition_1.RV-Pre1?
I feel good.
Personally, I think that for the search and refresh icons, you can just keep the icons themselves.
Indeed, it looks better the way you said. I have implemented it in the latest commit. (e4b98f565fcf37ef1076a03bf0322ebc357be9ed).
这样修改应该会破坏 Version 的序列化,我有空再看看。
官方下载源对愚人节版本的划定是“快照” The official download source defines the April Fool's Day version as a "snapshot" 我觉得没必要更改 I don't think it's necessary to make any changes
是的,但是我觉得不妨碍单独一个分类,其他启动器也有这个功能
https://github.com/HMCL-dev/HMCL/issues/3763
愚人节版本是比较特殊的版本,放在“快照”分类下感觉不太合适,而且找的时候也不方便找,希望添加“愚人节版本”分类。
我觉得你的实现方式太过危险,修改 GameRemoteVersion 可能会影响到其他地方的逻辑。
我在 #4141 中用更安全的方式重写了本功能,所以我会关闭本 PR。