camilladsp icon indicating copy to clipboard operation
camilladsp copied to clipboard

Configurable limit for Volume filters

Open HEnquist opened this issue 3 years ago • 4 comments

Volume filters should have min and max parameters. If the volume is set to a value outside the allowed range, the actual applied value should be clamped at the nearest limit.

HEnquist avatar Aug 21 '22 19:08 HEnquist

@HEnquist This is set as completed, but where can I set the clamp limit?

timsurber avatar Mar 30 '24 21:03 timsurber

This was not implemented as described here. Instead I added a limiter filter. It's a different but not equivalent solution to the problem of limiting the max volume going out. I should have added a comment about that when I closed this issue. And I probably should not have closed it. I'll reopen and implement this for 3.0.

HEnquist avatar Apr 01 '24 11:04 HEnquist

@HEnquist Would you consider adding a lower limit as well? When controlling it with an remote it can happen that you press the volume down button too long accidently, and then it can take quite a while to get up again.

timsurber avatar Apr 03 '24 20:04 timsurber

Adding a lower limit won't help with that. The limit does not limit what values the websocket interface accepts, it only clamps what the volume control actually applies.

HEnquist avatar Apr 03 '24 21:04 HEnquist