HEXRD
Update nfutil.py
Small bug in the plot oris function where the rotations call hadn't been updated.
Also someone had changed the code to separate the confidence map plotting. This was not the intended use. The confidence map gets plotted over the top to darken regions of low confidence.
Hello @darrencpagan! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:
- In the file
hexrd/grainmap/nfutil.py:
Line 1494:5: E265 block comment should start with '# ' Line 1496:5: E265 block comment should start with '# '
@darrencpagan Feel free to merge. That packaging failure was an issue that was recently fixed on master, so it shouldn't be an issue any longer.
@darrencpagan @psavery is this PR still valid? Please merge or close out this week.
I think this is valid and can be merged. Is there anything I need to do?
Darren C. Pagan, Ph.D. Assistant Professor, Materials Science and Engineering and Mechanical Engineering Associate, Institute for Computational and Data Sciences The Pennsylvania State University Office Phone: 814-863-0655
On Tue, Jul 30, 2024 at 1:06 PM Zack @.***> wrote:
@darrencpagan https://github.com/darrencpagan @psavery https://github.com/psavery is this PR still valid? Please merge or close out this week.
— Reply to this email directly, view it on GitHub https://github.com/HEXRD/hexrd/pull/631#issuecomment-2258816627, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZPYPQ2DGIE3CADIBPSORLZO7BY7AVCNFSM6AAAAABGFLSD52VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJYHAYTMNRSG4 . You are receiving this because you were mentioned.Message ID: @.***>
@darrencpagan I'll re-trigger the Github Action to make sure it works properly, and get this merged for you. Thanks.