gwt-material icon indicating copy to clipboard operation
gwt-material copied to clipboard

ProgressMixin doesn't support arbitrary HasProgress widget

Open gkresic opened this issue 5 years ago • 2 comments

Looking at ProgressMixin's generics declaration it's supposed to work with any UIObject that implements HasProgress interface.

However, ProgressMixin.showProgress supports only instances of MaterialCollapsibleItem and MaterialNavBar. Is there any specific reason why other widgets implementing HasProgress (like MaterialAutoComplete from addins) are not supported?

Simply adding MaterialProgress to MaterialAutoComplete works and since its the only other widget implementing HasProgress besides MaterialCollapsibleItem and MaterialNavBar, it looks it's safe to simply add progress widget to any HasProgress.

gkresic avatar Jul 09 '20 12:07 gkresic

I need to review this with our team - if ever that this will be confirmed then we might add this to 2.4.1 release

kevzlou7979 avatar Aug 10 '20 01:08 kevzlou7979

Ok we reviewed the ProgressMixin we will do the enhancements later on 2.5.0 for enhancements

kevzlou7979 avatar Aug 10 '20 22:08 kevzlou7979