guake icon indicating copy to clipboard operation
guake copied to clipboard

Allow Python versions >=3.10 and IPython alternate command as default shell options

Open novaTopFlex opened this issue 1 year ago • 1 comments

Please follow these steps before submitting a new Pull Request to Guake:

  • rebase on latest HEAD:

    $ git pull --rebase upstream master
    
  • hack your change

  • to execute the code styling, checks and unit tests:

    $ make style check reno-lint test
    
  • describe your change in a slug file for automatic release note generation, using:

    $ make reno SLUG=<short_name_of_my_feature>
    

    and edit the created file in releasenotes/notes/. You can see how reno works using pipenv run reno --help.

    Please use a generic slug (eg, for translation update, use translation, for bugfix use bugfix,...)

  • create new commit message

    $ <hack the code>
    $ git commit --all
    
  • If your change is related to a GitHub issue, you can add a reference using #123 where 123 is the ID of the issue. You can use closes #123 to have GitHub automatically close the issue when your contribution get merged

  • Semantic commit is supported (and recommended). Add one of the following line in your commit messages:

    # For a bug fix, uses:
    sem-ver: bugfix
    
    # For a new feature, uses:
    sem-ver: feature
    
    # Please do not use the 'breaking change' syntax (`sem-ver: api-break`),
    # it is reserved for really big reworks
    

This pull request is necessary to ensure that Python versions beginning with 3.10 are available as default shell options on the Guake terminal. Without this modification the newest Python version that would function on the Guake terminal is only Python 3.9, and Ubuntu 22.04 LTS (my host system) ships with Python 3.10 by default, causing the issue of Python 3.10 not appearing on my host system.

novaTopFlex avatar Apr 10 '24 20:04 novaTopFlex

This might be a simpler regex to evaluate

PYTHONS = re.compile(r"^[a-z]?python(\d(\.\d+)?)?$")

or

PYTHONS = re.compile(r"^[a-z]?python(?:\d(?:\.\d+)?)?$")

if you don't need to capture the version components.

SparkyBluefang avatar Jun 03 '24 04:06 SparkyBluefang