Griddle icon indicating copy to clipboard operation
Griddle copied to clipboard

Release 1.13.2 - Griddle now fully compatible with React 16

Open mDibyo opened this issue 7 years ago • 9 comments

Griddle major version

v1

Changes in this release

  • @types/prop-types #827
  • Upgrade typescript to ^2.8.0 #840
  • Upgrade recompose to ^0.25.1 #839

mDibyo avatar Dec 24 '18 08:12 mDibyo

@ryanlanciaux and other maintainers: I was able to get master installed by doing yarn add https://github.com/GriddleGriddle/Griddle.git#49306e7, but would be nice to just have a new package version. :)

UPDATE: A quirk with yarn prevents yarn add from being a feasible approach. yarn add runs the prepare script, but running yarn install for a project depending on the package does not, meaning this approach doesn't work in any deployment environments.

mDibyo avatar Dec 24 '18 08:12 mDibyo

Also, I had missed updating yarn.lock in #839 and #840, and this PR fixes that. (I can create a separate PR for fixing yarn.lock, if you guys would prefer that. )

mDibyo avatar Dec 24 '18 10:12 mDibyo

@ryanlanciaux @dahlbyk would be super duper nice to get this new version of the package. :) Anything I can do to help with this?

Our team is currently blocked on upgrading to React 16, since the current version of Griddle (v1.13.1) is not "officially" compatible with React 16. But that issue was resolved when #839 was merged. All we need now is a new version of the package, and we'd rather not depend on a private fork of the package.

mDibyo avatar Jan 09 '19 17:01 mDibyo

If using yarn, you can use the package.json#resolutions property to force the nested version resolution. In this case we added the following to our package.json file:

{
  "resolutions": {
    "griddle-react/recompose": "^0.25.1"
  }
}

JamesNimlos avatar Feb 18 '19 22:02 JamesNimlos

Referencing #856

docrinehart avatar Jul 02 '19 14:07 docrinehart

@ryanlanciaux This PR is invalidated by #849 , we should be able to close this with the next release.

docrinehart avatar Jul 09 '19 19:07 docrinehart

Any word on when this will be released?

LoganArnett avatar Jul 24 '19 14:07 LoganArnett

bump

plum-dawg avatar Oct 21 '19 19:10 plum-dawg

Anyway this can get merged so people can upgrade to react 16.x, this is the only thing holding it up it looks like.

beekerstudios avatar Dec 03 '19 17:12 beekerstudios