Griddle icon indicating copy to clipboard operation
Griddle copied to clipboard

recordCount why ignore it using localPlugin?

Open YosefMac opened this issue 8 years ago • 0 comments

Hi there!! this is really a question rather than issue, I was wondering why recordCount from the pageProperties is ignored using localPlugin ? I take a look in the code and it seems that in the maxPageSelector from dataSelectors.js are using indeed recordCount but when I check localSelectors.js the maxPageSelector use the data size.

I think it would be useful use recordCount when is defined by the user and if it doesn't defined use the data size. Because using data size do not show all the page in the dropdown when the data size is less that recordCount. I thought about doing a PR but maybe there is a good reason that I'm missing out for not using recordCount in the plugin

Thanks in advance!!!

YosefMac avatar Jul 26 '17 17:07 YosefMac