GriddleGriddle
useFixedHeader - columns are misaligned
When you use useFixedHeader=true, the table columns are misaligned with the header columns, just like in the image below.
My columns are even more broken than this. I would suggest that the plugin move over to using
I fixed this in my branch. It was that the TR used to space out the table did not contain any TDs - i've adapted the griddle source to support this in my branch on github.
It's not intended for pull requests as Griddle's authors seem to have abandoned this project in favour of a rewrite.
@aphillipo I'm sorry if I miscommunicated the state of this project. It is true that we are working to break apart the functionality into other modules (so rendering isn't so tied to grid logic, etc). These modules will be used in the main griddle project (this will allow for other enhancements that we'll be documenting a little later on). That all said we are not abandoning this project.
We are being a bit cautious about approving larger PRs because we are treating a lot of the open issues as acceptance criteria for the new stuff. What we are trying to avoid is having someone spend a lot of effort implementing a feature only to have it replaced a little later on.
This sounds like it would be a good candidate for a PR if you already have the work done.
Sorry for being so rude! I know you haven't abandoned it but I didn't think you were taking pull requests.
The code I have semi-duplicates the generation of a row code so while it fixes this bug it definitely is not perfect. I have no time to pull apart the row generation to avoid this duplication.
I would send a pull request but I've made so many other small changes I doubt either of us would want it merged.
Seeing as you have put in so much effort on Griddle I'll try my very best to find time to get only the things that fix this bug into a pull request.
Oh you weren't being rude at all. You bring up a totally valid concern -- I just wanted to clarify because I realize I may have been less than clear in the gitter chat when we talked on this.
I think this weekend we're going to start opening issues on the griddle-core / griddle-render projects and closing the ones here that we're working in those projects (that will make their way back here -- it's confusing, I know). That way we'll have a more accurate view of what is being worked on and what needs attention.
So when will I be able to replace old griddle with the new work you guys have been doing? Be nice to have a rough guess of when I can start testing it...
Seems like there are 2
