python-logging-loki icon indicating copy to clipboard operation
python-logging-loki copied to clipboard

readme example needs to "start()" the listener

Open john-devseek opened this issue 4 years ago • 1 comments

In the example demonstrating usage of QueueHandler and QueueListener, the listener is instantiated with the following line in the example: logging.handlers.QueueListener(queue, handler_loki)

Looking at the source code, the thread handling the queue is not instantiated or started until start() is called (so __init__ is not enough).

john-devseek avatar Oct 14 '21 22:10 john-devseek

Also, it seems a bit confusing you'd be using a Queue from multiprocessing instead of threading, without actually using processes.

parity3 avatar Oct 14 '21 22:10 parity3