[BUG] Tool dupe with Botania Spellbinding Cloth

[ALongStringOfNumbers]

Describe the bug Using the Botania Spellbinding Cloth to remove enchantments from GTCE tools (tested on the hammer) will instead decrement the durability of the enchanted tool and create a duplicate tool that is unenchanted. This issue was originally seen here: https://github.com/FTBTeam/FTB-Interactions/issues/1292 but the issue author did not report it so I thought that I would. Although this issue was reported in an FTB modpack, I reproduced this in a minimal environment.

Versions Forge: 14.23.5.2847 GTCE: 1.10.2.566 Botania: r1.10-363 Modpack: none Addons: none

Setup Playing Solo (only tested solo) New world generated Yes

Steps To Reproduce

1. Give yourself a GTCE tool (In this case it was an emerald hammer)
2. Enchant the tool in an enchanting table
3. Give yourself a Spellbinding Cloth.
4. In your 2x2 crafting grid (Although this works in the crafting table as well) place the Cloth and the enchanted tool
5. Shift left click on the output and fill your inventory with tools

Expected behavior No dupe. I am unsure if the enchantment wiping should work, but at the very least the tools should not be duplicated. If the enchantment wiping is deemed to be feasible, then the recipe should not decrement the durability on the tool.

Screenshots

[LAGIdiot]

Thank you for reporting this issue.

Accepted.

[PrototypeTrousers]

This is probably a bug with botania's spell binding cloth. Enchanting (in creative) a applied energistics Cutting knife and trying to disenchant will also dupe it. In common, GT tools and the Cutting knife both take damage as if it was a valid recipe.

[LAGIdiot]

That part about taking damage is little bit bothering me it seems that we are thinking this is valid crafting recipe and hammer should tool should be used but in reality it is not. Maybe just simple check of ? may prevent this. But I was not yet able to investigate this.

[Archengius]

It's definitely a bug on Botania side, I think Botania is not overriding one of IRecipe methods responsible for handling recipe refunds (e.g calling GetContainerItem on items used in crafting), which results in items in question being returned additionally to being result of the craft.