graylog2-server icon indicating copy to clipboard operation
graylog2-server copied to clipboard

Move filters from search to widgets on exporting to dashboard action

Open maxiadlovskii opened this issue 1 year ago • 3 comments

Description

As the dashboard doesn't have global search filter overrides, to fix an issue we have to copy all search filters from the search to each widget and remove them from search

Motivation and Context

fix: https://github.com/Graylog2/graylog-plugin-enterprise/issues/9023

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Refactoring (non-breaking change)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • [ ] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.

maxiadlovskii avatar Jan 17 '25 07:01 maxiadlovskii

Imo we should not mark the related issue as fixed, because we probably also need a migration to remove search filters which have been added to dashboards in the past. What do you think?

linuspahl avatar Jan 31 '25 14:01 linuspahl

Imo we should not mark the related issue as fixed, because we probably also need a migration to remove search filters which have been added to dashboards in the past. What do you think?

@linuspahl It makes sense... To avoid migration, we can also move global search filters to widgets on the saved dashboard load on FE.

maxiadlovskii avatar Feb 04 '25 13:02 maxiadlovskii

@maxiadlovskii I discussed it again with @dennisoelkers and @kmerz and maybe the best idea is to add the search filter functionality to the dashboards, too. Maybe this needs some more discussion, also with product / @Emy-01 .

janheise avatar Jun 12 '25 11:06 janheise