graylog2-server icon indicating copy to clipboard operation
graylog2-server copied to clipboard

Show Changes button on decorated message detail not working

Open kingzacko1 opened this issue 4 years ago • 1 comments

The button to Show Changes on a MessageDetail component for a decorated message no longer seems to be working.

Expected Behavior

If the Show Changes button is displayed on a decorated message, then clicking it should result in showing what changes were made with the search decorators.

Current Behavior

When the Show Changes button is displayed on a decorated message clicking it results in seemingly no action and nothing new displayed in the UI

Possible Solution

Possibly unrelated, but there is a React PropTypes error thrown in the browser console referencing the MessageDetail component when it is expanded. Maybe cleaning up this front end error would result in correct behavior

prop-types-err.log

Steps to Reproduce (for bugs)

  1. Create an input to receive messages (I just used a Random HTTP message generator)
  2. System > Configurations > Decorators Configuration > Create a new decorator to add/modify an existing field in the All Messages stream
  3. Send a message to your input (if not using randomly generated)
  4. Go to the All Messages stream and expand a message (this throws the attached React prop types error in the console for me in both Chrome and Firefox)
  5. The Show Changes button should be present after expanding the method and clicking it should result in no change to the UI

Context

Was trying to test out some back end changes to the DecorationStats object and confirm nothing on the front end was affected and found that these changes were not displaying.

Your Environment

My local dev environment

  • Graylog Version: 4.3
  • Java Version: OpenJDK 1.8
  • Operating System: Ubuntu
  • Browser version: Chrome - Version 96.0.4664.45 / Firefox - Version 94.0

kingzacko1 avatar Dec 06 '21 14:12 kingzacko1

When clicking to expand a message on the main search view, the following error happens. image

Warning: Failed prop type: Invalid prop `currentView.view` of type `View` supplied to `MessageField`, expected instance of `View`. in MessageField
Warning: Failed prop type: Invalid prop `currentView.view` of type `View` supplied to `MessageField`, expected instance of `View`. in MessageField (created by ConnectStoresWrapper[MessageField] stores=currentView) in ConnectStoresWrapper[MessageField] stores=currentView (created by MessageFields) in CustomHighlighting (created by MessageFields) in dl (created by MessageFields__MessageDetailsDL) in MessageFields__MessageDetailsDL (created by MessageFields) in MessageFields (created by MessageDetail) in div (created by Col) in Col (created by MessageDetail) in div (created by Row) in Row (created by Row) in Row (created by MessageDetail) in Provider (created by Context.Consumer) in WatchlistStatusProvider (created by MessageDetailsAdditionalProvider) in MessageDetailsAdditionalProvider (created by MessageDetailProviders) in ErrorBoundary (created by MessageDetailProviders) in MessageDetailProviders (created by MessageDetail) in Provider (created by MessageDetail) in MessageDetail (created by MessageTableEntry) in td (created by MessageTableEntry) in tr (created by MessageTableEntry__MessageDetailRow) in MessageTableEntry__MessageDetailRow (created by MessageTableEntry) in tbody (created by MessageTableEntry__TableBody) in MessageTableEntry__TableBody (created by MessageTableEntry) in MessageTableEntry (created by Context.Consumer) in Provider (created by MessageTable) in table (created by MessageTable__Table) in MessageTable__Table (created by MessageTable) in div (created by MessageTable__TableWrapper) in MessageTable__TableWrapper (created by MessageTable) in MessageTable (created by MessageList) in PaginatedList (created by MessageList) in div (created by MessageList__Wrapper) in MessageList__Wrapper (created by MessageList) in WindowDimensionsContextProvider (created by MessageList) in MessageList (created by ConnectStoresWrapper[MessageList] stores=currentView,searches) in ConnectStoresWrapper[MessageList] stores=currentView,searches (created by Visualization) in Visualization (created by Widget) in WidgetErrorBoundary (created by Widget) in EditWrapper (created by Widget) in div (created by WidgetFrame__WidgetWrap) in WidgetFrame__WidgetWrap (created by _default) in _default (created by Widget) in WidgetColorContext (created by ConnectStoresWrapper[WidgetColorContext] stores=colorRules) in ConnectStoresWrapper[WidgetColorContext] stores=colorRules (created by Widget) in Widget (created by WidgetComponent) in ExportSettingsContextProvider (created by WidgetComponent) in Provider (created by WidgetComponent) in DrilldownContextProvider (created by ConnectStoresWrapper[DrilldownContextProvider] stores=currentQuery,globalOverride) in ConnectStoresWrapper[DrilldownContextProvider] stores=currentQuery,globalOverride (created by WidgetComponent) in WidgetComponent (created by WidgetGridItem) in WidgetGridItem (created by WidgetGrid) in div (created by WidgetContainer__Container) in WidgetContainer__Container (created by ForwardRef) in ForwardRef (created by GridItem) in Resizable (created by GridItem) in DraggableCore (created by GridItem) in GridItem (created by ReactGridLayout) in div (created by ReactGridLayout) in ReactGridLayout (created by ResponsiveReactGridLayout) in ResponsiveReactGridLayout (created by WidthProvidedGridLayout) in WidthProvidedGridLayout (created by ReactGridContainer__StyledWidthProvidedGridLayout) in ReactGridContainer__StyledWidthProvidedGridLayout (created by ReactGridContainer) in ReactGridContainer (created by WithTheme(ReactGridContainer)) in WithTheme(ReactGridContainer) (created by WidgetGrid__StyledReactGridContainer) in WidgetGrid__StyledReactGridContainer (created by SizeMe) in Unknown (created by SizeMeRenderer(Component)) in SizeMeReferenceWrapper (created by SizeMeRenderer(Component)) in SizeMeRenderer(Component) (created by SizeMe(Component)) in SizeMe(Component) (created by SizeMe) in SizeMe (created by Grid) in Grid (created by WidgetGrid) in div (created by WidgetGrid__DashboardWrap) in WidgetGrid__DashboardWrap (created by WidgetGrid) in WidgetGrid (created by Query) in Query in div (created by Col) in Col (created by SearchResult__StyledCol) in SearchResult__StyledCol in div (created by Row) in Row (created by SearchResult__StyledRow) in SearchResult__StyledRow in Unknown (created by Context.Consumer) in HighlightMessageInQuery (created by Context.Consumer) in div (created by Grid) in Grid (created by PageContentLayout__StyledGrid) in PageContentLayout__StyledGrid (created by PageContentLayout) in WithGlobalNotifications (created by PageContentLayout) in div (created by PageContentLayout__Container) in PageContentLayout__Container (created by PageContentLayout) in PageContentLayout (created by Search__SearchArea) in Search__SearchArea (created by Context.Consumer) in div (created by Search__GridContainer) in Search__GridContainer (created by Context.Consumer) in HighlightingRulesProvider (created by Context.Consumer) in Provider (created by ViewAdditionalContextProvider) in ViewAdditionalContextProvider (created by Context.Consumer) in DefaultFieldTypesProvider (created by Context.Consumer) in SearchPageLayoutState (created by SearchPageLayoutProvider) in SearchPageLayoutProvider (created by Context.Consumer) in CurrentViewTypeProvider (created by ConnectStoresWrapper[CurrentViewTypeProvider] stores=view) in ConnectStoresWrapper[CurrentViewTypeProvider] stores=view (created by Context.Consumer) in WidgetFocusProvider (created by Search) in Search (created by SearchPage) in __WEBPACK_DEFAULT_EXPORT__ (created by SearchPage) in DashboardPageContextProvider (created by SearchPage) in DocumentTitle (created by SearchPageTitle) in SearchPageTitle (created by SearchPage) in SearchPage in SearchPage (created by StreamSearchPage) in StreamSearchPage in Unknown in Unknown (created by LoadableComponent) in LoadableComponent (created by Context.Consumer) in Route (created by AppRouter) in Switch (created by AppRouter) in div (created by App__PageContent) in App__PageContent (created by Context.Consumer) in RuntimeErrorBoundary (created by Context.Consumer) in ReportedErrorBoundary (created by Context.Consumer) in div (created by App__AppLayout) in App__AppLayout (created by Context.Consumer) in ScratchpadProvider (created by Context.Consumer) in App (created by AppRouter) in Route (created by AppRouter) in Switch (created by AppRouter) in RouterErrorBoundary (created by AppRouter) in Router (created by AppRouter) in AppRouter (created by LoggedInPage) in StreamsProvider (created by ConnectStoresWrapper[StreamsProvider] stores=streams) in ConnectStoresWrapper[StreamsProvider] stores=streams (created by LoggedInPage) in LicenseCheckProvider (created by GlobalContextProviders) in ErrorBoundary (created by GlobalContextProviders) in GlobalContextProviders (created by LoggedInPage) in Fe (created by GraylogThemeProvider) in GraylogThemeProvider (created by ThemeAndUserProvider) in CurrentUserPreferencesProvider (created by ThemeAndUserProvider) in TimeLocalizeProvider (created by ThemeAndUserProvider) in CurrentUserProvider (created by ThemeAndUserProvider) in ThemeAndUserProvider (created by LoggedInPage) in QueryClientProvider (created by DefaultQueryClientProvider) in DefaultQueryClientProvider (created by LoggedInPage) in LoggedInPage (created by LoadableComponent) in LoadableComponent (created by AppFacade) in AppFacade in Fe (created by GraylogThemeProvider) in GraylogThemeProvider in CustomizationProvider printWarning @ checkPropTypes.js:20 checkPropTypes @ checkPropTypes.js:82 validatePropTypes @ react.development.js:1714 createElementWithValidation @ react.development.js:1813 render @ connect.tsx:181 finishClassComponent @ react-dom.development.js:17160 updateClassComponent @ react-dom.development.js:17110 beginWork @ react-dom.development.js:18620 beginWork$1 @ react-dom.development.js:23179 performUnitOfWork @ react-dom.development.js:22157 workLoopSync @ react-dom.development.js:22130 performSyncWorkOnRoot @ react-dom.development.js:21756 eval @ react-dom.development.js:11089 unstable_runWithPriority @ scheduler.development.js:653 runWithPriority$1 @ react-dom.development.js:11039 flushSyncCallbackQueueImpl @ react-dom.development.js:11084 flushSyncCallbackQueue @ react-dom.development.js:11072 discreteUpdates$1 @ react-dom.development.js:21893 discreteUpdates @ react-dom.development.js:806 dispatchDiscreteEvent @ react-dom.development.js:4168

This error might be relevant for investigating the cause of the Show change button not working.

danotorrey avatar Jan 12 '22 20:01 danotorrey