Add Bezier unit tests

Open hannahli2010 opened this issue 3 years ago • 2 comments

Add tests for the Bezier functions that do not have any yet.

Jul 16 '22 18:07 hannahli2010

Deploying with Cloudflare Pages

Latest commit:	`b17e82c`
Status:	✅ Deploy successful!
Preview URL:	https://ed6594ff.graphite-master.pages.dev
Branch Preview URL:	https://bezier-unit-tests.graphite-master.pages.dev

View logs

Jul 27 '22 22:07 cloudflare-workers-and-pages[bot]

@hannahli2010 it looks like a number of these tests only try the endpoints (t = 0 and t = 1). Testing the middle (t = 0.5) would be good for those. Maybe you can find an online Bezier calculator, or hook it up to Bezier.js, to double check some of those values to avoid dogfeeding your tests with your implementation results.

Aug 08 '22 20:08 Keavon

I'm going ahead and merging this now to avoid keeping the branch open too long and getting stale. For the remaining code review comments I left, please open another PR when you guys have the time. Thanks!

Aug 14 '22 20:08 Keavon