Graphite icon indicating copy to clipboard operation
Graphite copied to clipboard

Allow zooming with two fingers on touchpads and mobile devices

Open bjorn3 opened this issue 4 years ago • 3 comments

bjorn3 avatar Feb 12 '22 19:02 bjorn3

On touch screens

Pinch to zoom involves using the multitouch parts of the JS API (see here) to track the two finger positions and see how they move relative to each other. There are some StackOverflows posts that may be helpful for this and some JS libraries that can be referenced (without directly stealing their code) but I don't think this warrants adding another dependency to the project, we should be able to implement this ourselves.

On trackpads

We need to apply a speed multiplier (so it doesn't feel so slow) when the Ctrl key isn't actually down, but is being reported as down by the browser lying during a wheel event: https://stackoverflow.com/questions/74312612/trackpad-pinch-causes-wheel-js-event-with-ctrlkey-true-how-to-tell-if-the-u and https://danburzo.ro/dom-gestures/

Keavon avatar Feb 15 '22 21:02 Keavon

Hi @Keavon

I want to work on this issue. Let me know the deadline for this Task.

themujahidkhan avatar Mar 12 '24 10:03 themujahidkhan

@themujahidkhan Upon taking a closer look at this, I don't currently have the bandwidth to help land this feature since it's not currently a very high priority. Would you mind finding something else please? I removed the Good First Issue task.

Keavon avatar Mar 12 '24 10:03 Keavon