GraphiteEditor
Clear artboard
| 📦 Build Complete for ac49479745cde3c23289a54118075b5ccab06b6e |
|---|
| https://5993b57e.graphite.pages.dev |
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
I would like to see the artboards name/position/downstream connnector/upstream connectors being saved, then the artboard is deleted, a layer node is created, its name/position are set, then it is reconnecting. All using the same messages as if the user was to do it.
Also, make sure to start and end a transaction at the start and end of the message. Its also important that no mutable network interface functions are called in a message that has a start/end transaction.
Optionally, it would also be nice if the artboards position is then used to set the transform of the new layer, so that the contents stay at the same place. This would require using a monitor node to access the artboard data, where the translation is stored. This could also be used to improve #2028. This would probably be outside the scope of the PR, so you could leave a TODO.
I'll mark this as a draft until those comments are addressed. Thanks for taking the time to review this, @adamgerhant.
I would like to see the artboards name/position/downstream connnector/upstream connectors being saved, then the artboard is deleted, a layer node is created, its name/position are set, then it is reconnecting. All using the same messages as if the user was to do it.
You want to reduce loops by this right?
You can use however many loops are necessary to achieve the correct behavior
Just checking in on the status of this @moOsama76.
I was taking a break, will do it this week
I'll close this PR for now, but please feel free to reopen it once you've addressed the code review feedback from Adam.
I'll close this PR for now, but please feel free to reopen it once you've addressed the code review feedback from Adam.
No problem I am getting back soon I promise :)