Graphite icon indicating copy to clipboard operation
Graphite copied to clipboard

Fix: empty folder's disappearing when copying

Open Tiger3018 opened this issue 1 year ago • 8 comments

TODO:

  • [x] portfolio_message omit copy event of the empty folder

Related: #1452, #1633

Tiger3018 avatar Mar 31 '24 18:03 Tiger3018

Notes:

For folder layers, DocumentNode.inputs seems to be [Child_node/Value, Sibling_node]. It's not well documented yet.

Tiger3018 avatar Mar 31 '24 18:03 Tiger3018

That is correct in the current main branch @Tiger3018, however @Keavon is currently reversing the ordering of those inputs (I'm unsure why) in a branch in someone's fork. For documentation on what the inputs are, you can look at the implementation (here the ConstructLayerNode struct) and also the document_node_types.rs file has a string name for the inputs to a node.

0HyperCube avatar Mar 31 '24 19:03 0HyperCube

For highlighting and group issues, it only appeared in Just a Potted Cactus and Valley of Spires example files. New document and two other example files didn't affected. Maybe a document version issue?

Mark this PR ready for review.

Tiger3018 avatar Apr 01 '24 02:04 Tiger3018

!build

Keavon avatar Apr 01 '24 02:04 Keavon

📦 Build Complete for 30366bab1489d4637da3cb0befe42a6ec2fe0543
https://2696d198.graphite.pages.dev

github-actions[bot] avatar Apr 01 '24 03:04 github-actions[bot]

This PR is not related to discovered issues formerly, and can be merged

Tiger3018 avatar Apr 05 '24 08:04 Tiger3018

I'm sorry, I actually still can't figure out what this PR addresses. What was the original issue or todo item? Can you please edit the PR description to mention only that?

Keavon avatar Apr 06 '24 05:04 Keavon

@Keavon I have removed the portfolio_message to clarifying just the phenomenon in the PR title, and have removed the mention of new issue in the description.

Tiger3018 avatar Apr 06 '24 07:04 Tiger3018

I'm still not sure precisely what this PR is about but I think it's already solved by the changes made in #1712 so I will close this as it's redundant.

Keavon avatar Apr 29 '24 06:04 Keavon