Mohammad Dohadwala

Results 36 comments of Mohammad Dohadwala

Click here to download https://github.com/maca134/MBCon/releases/download/0.0.0.2/mbcon-0.0.0.2.zip

![image](https://user-images.githubusercontent.com/4633243/67515885-a128e680-f6b0-11e9-975a-321dc2758392.png) I can do this in the [ws](https://www.npmjs.com/package/ws) package but not on this one, any idea why it's not supported?

Why are GH Actions not running on this PR?

Hi @tidy-dev, thank you for the detailed feedback. Regarding the issue requirement - You're absolutely right. I should have first opened an issue to discuss the need and gather feedback...

Thank you @tidy-dev, I'm happy to work on the suggested improvements while your team continues the discussion: - Update terminology to "Included in commit/Excluded from commit" - Add a "Clear...

Hi @tidy-dev I have added the changes that you requested. Please take a look now. - Update terminology from "staged/unstaged" to "included in commit/excluded from commit" - Add clear filters...

- Updated filter state interface - Refactored to use the new `FileListFilterState` interface for better type safety - Improved filter statistics naming - Added "Changes" prefix to filter stats for...

@tidy-dev, thanks for the extensive review once again. I have addressed them all with the best of my ability. Let me know if I missed anything.

- Removed duplicate IFileFilterState interface from filter-changes-logic.ts - Now using single IFileListFilterState interface from app-state.ts throughout the codebase - Exported IChangesListItem from filter-changes-list.tsx instead of duplicating it - Kept getCheckBoxValueFromIncludeAll...