google-map
google-map copied to clipboard
attribute native hidden and title in Polymer 2
Solved the failure in polymer 2 with the hidden attribute.
When you use the Google Maps component in Polymer 2 the hidden attribute is not working as in Polymer 1,
it only works the first time.
It seems that with the native attributes of html 'hidden', 'title', etc ... in polymer 2 in this
component they do not react to the change.I have reviewed the 'attributeChanged' method and it
appears as deprecated and according to the official documentation they recommend using
the 'attributeChangedCallback' method, but it behaves the same with the native attributes.
I imagine that since they are native attributes they have a behavior that in polymer 1 if it worked
but in polymer 2 it does not do in binding.
Solution: The first solution was to create a property that would replace the behavior of the hidden
or the title, but the final solution is much simpler. You have to declare the native
attributes 'hidden' or 'title' as properties of the component, in this way Native attributes
work correctly
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.
What to do if you already signed the CLA
Individual signers
- It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
Corporate signers
- Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
- The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
- The email used to register you as an authorized contributor must also be attached to your GitHub account.
I signed it!