google-map icon indicating copy to clipboard operation
google-map copied to clipboard

Issues with Dom-repeat and Map Markers

Open msamitahir opened this issue 8 years ago • 5 comments

I was unable to get the data binding to work when using google-map-markers inside dom-repeat template. Made 2 changes to the code to enable dynamic updating of google map markers and their contents. The following code now works well to render markers on google map when bound to an items array.

<google-map map="{{map}}" api-key=xxxx latitude="[[lat]]" longitude="[[lon]]">
        <template is="dom-repeat" items="[[array]]">
          <google-map-marker map="[[map]]" latitude="[[item.lat]]" longitude="[[item.lon]]" title="[[item.title]]" >[[item.content]]</google-map-marker>
        </template>
</google-map>

Possible issues resolved #299 #319 #297 #288 #263

msamitahir avatar Mar 06 '17 14:03 msamitahir

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

googlebot avatar Mar 06 '17 14:03 googlebot

I am having the same issue with the infowindow. I tested your update to infowindows and it fixed the issue. I am now getting a side effect where opening the info window on one marker will trigger opening other markers and sometimes close the clicked marker

jparish3 avatar Mar 08 '17 15:03 jparish3

Hi jparish3,

  • Have you applied all 3 changes that I made ?
  • Do these issues appear on first rendering or after subsequent updates are made ?

I had tested it out with 4 markers and text only content in infoWindow and did not notice this unusual behavior.

You can also check what are the versions of your dependencies using bower list. I am currently using the following versions of the google map dependencies: ├─┬ google-map#1.2.0 │ ├─┬ google-apis#1.1.7 │ │ ├─┬ iron-jsonp-library#1.0.4 │ │ │ └── polymer#1.8.0 │ │ └── polymer#1.8.0 │ ├── iron-resizable-behavior#1.0.5 │ ├── iron-selector#1.5.2 │ └── polymer#1.8.0

Thanks,

msamitahir avatar Mar 09 '17 01:03 msamitahir

I signed it!

msamitahir avatar Mar 09 '17 01:03 msamitahir

CLAs look good, thanks!

googlebot avatar Mar 09 '17 01:03 googlebot