GoogleWebComponents
this.markers is set to readyOnly: true in the properties. this.marker…
Fixes issue #353
markers property is set to readOnly and will throw an error if set directly.
this.markers = VALUE is incorrect.
this._setMarkers(VALUE) is correct.
Currently it is doing both and will fail in a strict mode.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
:memo: Please visit https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.
- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
- If you signed the CLA as a corporation, please let us know the company's name.
I signed it!
On Thu, Feb 16, 2017 at 4:29 PM, googlebot [email protected] wrote:
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
📝 Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.
Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.
- If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data https://cla.developers.google.com/clas and verify that your email is set on your git commits https://help.github.com/articles/setting-your-email-in-git/.
- If you signed the CLA as a corporation, please let us know the company's name.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/GoogleWebComponents/google-map/pull/354#issuecomment-280511207, or mute the thread https://github.com/notifications/unsubscribe-auth/APiim_GPFFFr81Ta24pifWIqvIuANPjBks5rdOnQgaJpZM4MDuao .
-- Brian McBride *CTO *| Zeppidy, Inc. https://zeppidy.com/ 4800 SW Meadows Rd, Suite 300, Lake Oswego, OR 97035 Facebook http://facebook.com/zeppidy | Linkedin https://www.linkedin.com/company/zeppidy | Twitter https://twitter.com/zeppidy | Angel https://angel.co/zeppidy | Google+ https://plus.google.com/+Zeppidy
This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify [email protected] immediately and delete this e-mail from your system. This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited.
Not sure why there's a conflict, but this change is required to be able get fit-to-markers to work. Can we get this merged?
