skaffold icon indicating copy to clipboard operation
skaffold copied to clipboard

Triggered actionable error is not showing the proper message

Open renzodavid9 opened this issue 3 years ago • 0 comments

Expected behavior

When an actionable error is triggered, that is not wrap inside an error type, the action text associated with it should be shown as part of the error.

Actual behavior

Instead, only the error message appears in the error.

Information

  • Skaffold version: v2.0.0-beta1-33-gf30cf99c0
  • Operating system: MacOS
  • Installed via: local build

Steps to reproduce the behavior

  1. From the source code, trigger an Actionable error, without wrapping it inside an error type
  2. In the console, once the Actionable error appears, only the error message is shown, the action text associated with it does not appear

It looks like in https://github.com/GoogleContainerTools/skaffold/blob/main/pkg/skaffold/errors/errors.go#L90, in the ShowAIError function, we are unwrapping the error once, so, if we return an Actionable error directly, we are not able to recognize it with the proper type.

renzodavid9 avatar Aug 22 '22 17:08 renzodavid9