kpt-config-sync icon indicating copy to clipboard operation
kpt-config-sync copied to clipboard

register the status reader for rollout objects

Open chunglu-chou opened this issue 3 years ago • 2 comments

This change utilizes the new functions in cli-utils and kpt to register the status reader for rollout objects in the applier builder. Note: since it depends on the new version of cli-utils and kpt, this PR can be tested only after the new dependencies are released and imported.

chunglu-chou avatar Aug 25 '22 17:08 chunglu-chou

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chunglu-chou Once this PR has been reviewed and has the lgtm label, please assign karlkfi for approval by writing /assign @karlkfi in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Aug 25 '22 17:08 google-oss-prow[bot]

Hi @chunglu-chou. Thanks for your PR.

I'm waiting for a GoogleContainerTools member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

google-oss-prow[bot] avatar Aug 25 '22 17:08 google-oss-prow[bot]

Closing outdated PR. Please reopen if it's still active.

janetkuo avatar Jul 11 '23 20:07 janetkuo