GoogleContainerTools
WIP Build node images with standardised format
Just a first draft @loosebazooka, not that happy with having two blocks of NODEJS, one with distro suffix, and one without.
Any clever ideas how to merge them into one?
As far as I understand, the container_push rules pushes the images to the image registry like nodejs<version>-debian<version>:latest-<arch>, and images have to be pushed to registry to be able to create manifests.
Perhaps in the manifest creation script, we can use the nodejs<version>-debian<version>:latest-<arch> images to create the nodejs<version>:latest manifests, without having to have its own NODEJS block?
I don't remember, had some vacation. I think there still were some changes I wanted to do with the cloudbuild docker script, but I think that would affect more images, and is suitable for its own PR.
The examples are failing, as they're trying to pull the images this PR will publish
@omBratteng Do the examples script(s) need to be modified to help this pass or can it be merged? I see https://github.com/GoogleContainerTools/distroless/pull/1083 is also dependent on this PR
The test is failing, because it is trying to use the new images made with this PR. If the goal is all checks passed, I could undo the example tests, and then open a new PR for those after this is merged.
I will rebase #1083 once this is merged, as it is dependent on the changes done here.
I think that's fine, we can let that test fail.
just kidding, yeah lets move that test update to a new PR.
I have reverted the examples to use the old tags, and I'll prepare a PR to update the tests.
(tags wont deprecate for 6 months)
Which aligns up closely with the EOL of node14
How about deprecate the old naming 2023-04-30, that matches with the EOL of node 14, so we can drop the non-manifested builds too. https://github.com/GoogleContainerTools/distroless/pull/1083#issuecomment-1184555454