container-structure-test icon indicating copy to clipboard operation
container-structure-test copied to clipboard

feat: Add support for --cap-drop

Open ddl-ebrown opened this issue 2 years ago • 4 comments

  • Support for --cap-add was added as part of https://github.com/GoogleContainerTools/container-structure-test/pull/327

  • This rounds out the feature set to also include support for --cap-drop

  • Updates tests to drop "chown" capability and verify doing so works

  • closes https://github.com/GoogleContainerTools/container-structure-test/issues/389

FYI - make test fails against the head of the main branch on my M1 -- which I didn't have time to diagnose. I'm using CI to verify that the tests behave properly.

ddl-ebrown avatar Oct 24 '23 18:10 ddl-ebrown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Oct 24 '23 18:10 google-cla[bot]

uh, sorry no one looked at this, I get to spend a little time now and then trying to maintain this, if you can rebase this and update it, I can merge it in.

loosebazooka avatar Feb 21 '24 23:02 loosebazooka

@loosebazooka updated

ddl-ebrown avatar Feb 29 '24 15:02 ddl-ebrown

Looks like we've got failing tests

FAIL: Run options (capabilities, bindMounts) test case failed

Will take a closer look

ddl-ebrown avatar Feb 29 '24 15:02 ddl-ebrown