GoogleContainerTools
feat: golang / dlv 1.23 support
Delve 1.20 no longer works properly with newer Golang versions (e.g. err variables show as nil even when non-nil). Updating to 1.23.0 which appears to fix the issue.
I included some changes I needed to run the tests locally (e.g. disable pushing integration test images), not sure if needed for CI but I don't think should hurt. I also removed the tests for now unsupported Golang versions.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
![google-cla[bot] avatar](https://avatars.githubusercontent.com/in/42202?v=4 "Published by a pub.dev verified publisher"){kind=small}
Note previous (unmerged) PR https://github.com/GoogleContainerTools/container-debug-support/pull/138 for 1.22
Would really be nice to get this merged. Odd how this repo seems so neglected.
@syntastical I reached out in multiple places in Kubernetes slack and haven't gotten a response, just pinged again so we'll see 🤷 If anyone has connections to help get this through would be appreciated.
@zarenner maybe try adding @briandealwis as a reviewer or maybe @GoogleCloudPlatform. The last merged pull request was approved by @briandealwis (https://github.com/GoogleContainerTools/container-debug-support/pull/132).
No permission to directly add reviewers unfortunately.
I see some discussion in https://github.com/GoogleContainerTools/skaffold/pull/9553 about org structure change. @ericzzzzzzz mentions to use @GoogleContainerTools/skaffold-team if I understand correctly, but that doesn't seem to resolve.
Also adding @plumpy as recent approver in Skaffold repo.
Awesome, thanks (and sorry I didn't have time yet to get back around to this)!