Google Code Exporter
Google Code Exporter
``` Back to work on this. Some observations: The problem is truly repainting, not scrolling. Scrolling just makes the repainting failure visible. Therefore, ScrollBits is exonerated for the time being....
``` For example, if you shrink the font down with Cmd-Minus and get the logical scrollframe size down below that critical limit, it displays and more importantly repaints fine. ```...
``` Most of yesterday and this morning in the debugger yielded the following. In nsViewManager::Refresh, when the Y of the bounding box exceeds the maximum screen height, the scroll goes...
``` Disabling double buffering fixes the bug!! nsViewManager::Refresh // check if the rendering context wants double-buffering or not if (aContext) { PRBool contextWantsBackBuffer = PR_TRUE; aContext->UseBackbuffer(&contextWantsBackBuffer); if (!contextWantsBackBuffer) aUpdateFlags &=...
``` NS_VMREFRESH_DOUBLE_BUFFER unsurprisingly is only in nsViewManager, and the only two parts that are affected by the flag are also in ::Refresh: if ((aUpdateFlags & NS_VMREFRESH_DOUBLE_BUFFER) && ds) { //...
``` In gfxComponent, nsRenderingContextMac::CopyOffScreenBits, at Rect macSrcRect, macDstRect; ::SetRect(&macSrcRect, x, y, x + dstRect.width, y + dstRect.height); ::SetRect(&macDstRect, dstRect.x, dstRect.y, dstRect.x + dstRect.width, dstRect.y + dstRect.height); // breakpoint here The...
``` However, the obvious change, ::SetRect(&macDstRect, dstRect.x, (dstRect.y >= 1080 || dstRect.y + dstRect.height > 1080) ? 1080-dstRect.height : dstRect.y, dstRect.x + dstRect.width, (dstRect.y >= 1080 || dstRect.y + dstRect.height...
``` But this workaround in nsViewManager::Refresh does fix it reliably and with a minimum of jitter: nsRect damageRectInPixels; aRegion->GetBoundingBox(&damageRectInPixels.x, &damageRectInPixels.y, &damageRectInPixels.width, &damageRectInPixels.height); if (damageRectInPixels.y >= 1080 || damageRectInPixels.y + damageRectInPixels.height...
``` This does not fix issue 28, but I expected that. ``` Original comment by `[email protected]` on 19 Jan 2010 at 12:38
``` Here is the code that works on both the MDD G4 and the PB1400, and accounts for screen height. I moved the code that converts damageRect into appunits up...