python-docs-samples icon indicating copy to clipboard operation
python-docs-samples copied to clipboard

feat(composer): pause/unpause DAGs in one operation

Open dkurzaj opened this issue 4 months ago • 3 comments

Description

Fixes #10805

When the Airflow instance version is >= 2.9.0 it now uses only one environments.executeAirflowCommand operation (consuming 25 write quota units) for all the DAGs, instead one operation per DAG. It's also way faster (during experimentation, it took 13,54ms per DAG to pause with the new method).

Checklist

dkurzaj avatar Oct 03 '25 12:10 dkurzaj

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Oct 03 '25 12:10 google-cla[bot]

Summary of Changes

Hello @dkurzaj, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the Cloud Composer DAG management script by enabling the pausing or unpausing of all DAGs in an environment with a single command. The change intelligently detects the Airflow version to apply the most efficient method: new bulk operations for modern Airflow versions (2.9.0+) and the existing iterative approach for older versions. This improvement streamlines DAG management and ensures compatibility across different Composer environments.

Highlights

  • Bulk DAG Operations: Introduced new static methods pause_all_dags and unpause_all_dags in composer_dags.py to allow pausing or unpausing all DAGs within a Google Cloud Composer environment in a single operation, leveraging gcloud commands with regex.
  • Airflow Version Compatibility: Implemented logic to differentiate between Airflow versions. For Airflow versions 2.9.0 and above, the new bulk operations are used. For older versions, the existing per-DAG iteration logic is maintained to ensure backward compatibility.
  • Code Refactoring: The main function in composer_dags.py was refactored to separate the version-specific logic into legacy_operations and modern_operations functions, improving code organization and readability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

[^1]: Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

gemini-code-assist[bot] avatar Oct 03 '25 12:10 gemini-code-assist[bot]

I don't know why all the Kokoro CI checks are pending with: "Expected — Waiting for status to be reported"

dkurzaj avatar Oct 20 '25 10:10 dkurzaj