python-docs-samples icon indicating copy to clipboard operation
python-docs-samples copied to clipboard

feat: Create sample for routeoptimization

Open bshi opened this issue 1 year ago • 6 comments

Description

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

bshi avatar Aug 07 '24 21:08 bshi

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • [ ] Refresh this comment

snippet-bot[bot] avatar Aug 07 '24 21:08 snippet-bot[bot]

Tests blocked by API enablement (or enablement propagation)

bshi avatar Aug 07 '24 22:08 bshi

Enabled the api in the testing project, re-running tests.

davidcavazos avatar Aug 14 '24 19:08 davidcavazos

  File "/workspace/routeoptimization/snippets/optimize_tours_test.py", line 26, in test_call_sync_api
    for val in (got.routes, got.visits, got.metrics):
                            ^^^^^^^^^^
  File "/workspace/routeoptimization/snippets/.nox/py-3-12/lib/python3.12/site-packages/proto/message.py", line 906, in __getattr__
    raise AttributeError(
AttributeError: Unknown field for OptimizeToursResponse: visits

Looks like that field doesn't exist?

davidcavazos avatar Aug 14 '24 19:08 davidcavazos

@davidcavazos I apologize for the delay. Addressed your comments.

bshi avatar Jan 08 '25 18:01 bshi

Since this PR was created, we're introduced Python 3.13 testing. Please rebase this PR to ensure this check passes (if this API doesn't yet support Python 3.13, please update the noxfile to ignore this version)

glasnt avatar Mar 05 '25 04:03 glasnt

Hi! You haven't replied to this PR in 6 months; it looks like this change is no longer a priority for you.

If this PR has been closed in error, please re-open and address previous review comments ✨

glasnt avatar Aug 28 '25 23:08 glasnt