prometheus icon indicating copy to clipboard operation
prometheus copied to clipboard

Add test for missing make vendor run

Open bwplotka opened this issue 1 year ago • 3 comments

Proposal

We constantly forget to do go mod vendor, no CI check for this?

bwplotka avatar Jun 11 '24 10:06 bwplotka

Usually the build fails if you don't run go mod vendor. We could add tidy and vendor to the regen target, I suppose?

bernot-dev avatar Jun 11 '24 11:06 bernot-dev

It's actually a part of the make regen target already, which calls the presubmit.sh script to execute various commands.

pintohutch avatar Jun 11 '24 12:06 pintohutch

Oh - and in Github CI in the validate step, where it ensures there's no diff after running.

Could potentially be improved though :)

pintohutch avatar Jun 11 '24 12:06 pintohutch

None of those works on prometheus, I think you refer to prometheus-engine.

Anyone, vendoring has been moved to our mirror so no need for this anymore!

bwplotka avatar Jul 10 '25 21:07 bwplotka