opentelemetry-operations-python icon indicating copy to clipboard operation
opentelemetry-operations-python copied to clipboard

Update CloudMonitoringMetricsExporter with the near latest version of OpenTelemetry

Open TseEnSun opened this issue 3 years ago • 6 comments

TseEnSun avatar Jul 12 '22 15:07 TseEnSun

@TseEnSun thanks for the PR! Apologies for not looking sooner, I was away on vacation. Any chance you'd like to continue help on this and get the tests passing?

aabmass avatar Aug 04 '22 18:08 aabmass

@aabmass, Sure, I would like to help, although I already know this implementation will not work correctly. How can I see the result of these checks?

TseEnSun avatar Aug 05 '22 03:08 TseEnSun

Why go towards the release candidate of .12 on this instead of the current stable version?

Is the plan here to hold this PR until the full release?

andaag avatar Aug 05 '22 09:08 andaag

Why go towards the release candidate of .12 on this instead of the current stable version?

Is the plan here to hold this PR until the full release? @andaag Since opentelemetry-python released the 1.0.0 version, they made the metrics API an interval package until 1.12.0rc. I was trying to integrate with the cloud monitor metrics and open-telemetry. Thus, I tried to implement this by myself and come to this PR.

TseEnSun avatar Aug 05 '22 10:08 TseEnSun

Since opentelemetry-python released the 1.0.0 version, they made the metrics API an interval package until 1.12.0rc. I was trying to integrate with the cloud monitor metrics and open-telemetry. Thus, I tried to implement this by myself and come to this PR.

Aha, that explains why I find it so hard to combine these packages and get a working setup. That makes sense 👍. I'll be looking forward to 1.12 then, thanks!

andaag avatar Aug 06 '22 08:08 andaag

Sharing that 1.12.0 is out, in case this is unblocked now

JishnuM avatar Aug 11 '22 01:08 JishnuM

Thanks for taking a stab at this. I've opened a separate PR https://github.com/GoogleCloudPlatform/opentelemetry-operations-python/pull/204 and decided to gut some of the code and tests as so much of it is no longer applicable.

aabmass avatar Nov 07 '22 18:11 aabmass