nodejs-docs-samples icon indicating copy to clipboard operation
nodejs-docs-samples copied to clipboard

feat: tpu_vm_create/get/list/delete/stop/start

Open gryczj opened this issue 1 year ago • 2 comments

Description

Fixes #<ISSUE-NUMBER>

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • [x] I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • [x] Tests pass: npm test (see Testing)
  • [x] Lint pass: npm run lint (see Style)
  • [ ] These samples need a new API enabled in testing projects to pass (let us know which ones)
  • [ ] These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • [x] This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • [x] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • [x] This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • [ ] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • [ ] Please merge this PR for me once it is approved

gryczj avatar Oct 03 '24 13:10 gryczj

Here is the summary of changes.

You are about to add 6 region tags.

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • [ ] Refresh this comment

snippet-bot[bot] avatar Oct 04 '24 10:10 snippet-bot[bot]

One important note: The TPUs are a product separate from Compute (that's more politics than technical separation), but they should have their own folder. So please extract the TPU related code from the compute folder and make a new tpu folder in the root of the repo. (You'll also need to edit CODEOWNERS file (copy the configuration for compute)).

Now, as for the fate of this PR - I'm trying to get in touch with the team responsible for the TPU product and their library. Hopefully, there will be some updates to the library, maybe solving the networking issue. That's why for now, I put a do not merge label on this PR - let's wait and see what the team has to say. If they won't have any good news for us with reasonable timing, we'll merge this.

m-strzelczyk avatar Oct 11 '24 11:10 m-strzelczyk

Due to high costs of TPU Nodes, it was decided to use mocks in the tests.

gryczj avatar Nov 12 '24 15:11 gryczj