fix: compute_hyperdisk_create_from_pool
Description
Fixes #<ISSUE-NUMBER>
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
- [x] I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
- [x] Tests pass:
npm test(see Testing) - [x] Lint pass:
npm run lint(see Style) - [ ] These samples need a new API enabled in testing projects to pass (let us know which ones)
- [ ] These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
- [x] This pull request is from a branch created directly off of
GoogleCloudPlatform/nodejs-docs-samples. Not a fork. - [ ] This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
- [ ] This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
- [ ] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
- [x] Please merge this PR for me once it is approved
@subfuzion My proposal is to merge tests for compute_hyperdisk_pool_create and compute_hyperdisk_create_from_pool. First we test if pool was created correctly and then we use this pool to create a new hyperdisk. By doing it this way we reduce number of operations for storagePool(there is a possibility to create only 5 new pool per project per hour and 10 storage pools per day). When developing compute directory is it really easy to exceed that. Additonaly I added logic to control disk and pool deletion and thank to this we could get rid of those timeouts in before() and after() methods. What do you think about this solution?