GoogleCloudPlatform
[#15779] Add google_network_security_firewall_endpoint_association resource
Adds the new google_network_security_firewall_endpoint_association resource.
fixes hashicorp/terraform-provider-google/issues/15779
Release Note Template for Downstream PRs (will be copied)
networksecurity: new `google_network_security_firewall_endpoint_association` resource
Hello! I am a robot. It looks like you are a: ~Community Contributor~ Googler ~Core Contributor~. Tests will run automatically.
@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 2 files changed, 169 insertions(+)) Terraform Beta: Diff ( 5 files changed, 969 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 106 insertions(+))
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_network_security_firewall_endpoint_association (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_network_security_firewall_endpoint_association" "primary" {
tls_inspection_policy = # value needed
}
Tests analytics
Total tests: 0
Passed tests 0
Skipped tests: 0
Affected tests: 0
Click here to see the affected service packages
- networksecurity
$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR}}$ View the build log
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 2 files changed, 169 insertions(+)) Terraform Beta: Diff ( 5 files changed, 969 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 106 insertions(+))
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_network_security_firewall_endpoint_association (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_network_security_firewall_endpoint_association" "primary" {
firewall_endpoint = # value needed
labels = # value needed
location = # value needed
name = # value needed
network = # value needed
parent = # value needed
tls_inspection_policy = # value needed
}
Tests analytics
Total tests: 0
Passed tests 0
Skipped tests: 0
Affected tests: 0
Click here to see the affected service packages
- networksecurity
$\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR}}$ View the build log
/gcbrun
@trodge can you please help me to run the tests again? It got stuck for some reasons..
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 2 files changed, 169 insertions(+)) Terraform Beta: Diff ( 5 files changed, 966 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 106 insertions(+))
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_network_security_firewall_endpoint_association (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_network_security_firewall_endpoint_association" "primary" {
tls_inspection_policy = # value needed
}
Tests analytics
Total tests: 36
Passed tests: 34
Skipped tests: 2
Affected tests: 0
Click here to see the affected service packages
- networksecurity
$\textcolor{green}{\textsf{All tests passed!}}$ View the build log
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
Terraform GA: Diff ( 2 files changed, 169 insertions(+)) Terraform Beta: Diff ( 5 files changed, 1006 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 106 insertions(+))
Missing test report
Your PR includes resource fields which are not covered by any test.
Resource: google_network_security_firewall_endpoint_association (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:
resource "google_network_security_firewall_endpoint_association" "primary" {
tls_inspection_policy = # value needed
}
Tests analytics
Total tests: 36
Passed tests: 34
Skipped tests: 2
Affected tests: 0
Click here to see the affected service packages
- networksecurity
$\textcolor{green}{\textsf{All tests passed!}}$ View the build log