magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Feature/vertexai featuregroups resource

Open kkram01 opened this issue 2 years ago • 12 comments

This PR is to create terraform provider for feature groups resource in Vertex AI. (https://cloud.google.com/vertex-ai/docs/reference/rest/v1/projects.locations.featureGroups)

Release Note Template for Downstream PRs (will be copied)

`google_vertexai_feature_group`

kkram01 avatar Dec 18 '23 10:12 kkram01

Hello! I am a robot. It looks like you are a: ~Community Contributor~ Googler ~Core Contributor~. Tests will run automatically.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician avatar Dec 18 '23 10:12 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 4 files changed, 983 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 4 files changed, 983 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 145 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_feature_group (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_feature_group" "primary" {
  big_query {
    entity_id_columns = # value needed
  }
  description = # value needed
}

modular-magician avatar Dec 18 '23 10:12 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 1139 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 5 files changed, 1139 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 145 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_feature_group (3 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_feature_group" "primary" {
  description = # value needed
}

modular-magician avatar Dec 18 '23 11:12 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 1141 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 5 files changed, 1141 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 145 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_feature_group (3 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_feature_group" "primary" {
  description = # value needed
}

modular-magician avatar Dec 18 '23 12:12 modular-magician

Tests analytics

Total tests: 3301 Passed tests 2962 Skipped tests: 337 Affected tests: 2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccVertexAIFeatureGroup_vertexAiFeaturegroup_basic|TestAccVertexAIFeatureGroup_vertexAiFeaturegroupBasicExample

Get to know how VCR tests work

modular-magician avatar Dec 18 '23 12:12 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccVertexAIFeatureGroup_vertexAiFeaturegroupBasicExample[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccVertexAIFeatureGroup_vertexAiFeaturegroup_basic[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Dec 18 '23 13:12 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 1141 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 5 files changed, 1141 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 145 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_vertex_ai_feature_group (3 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_vertex_ai_feature_group" "primary" {
  description = # value needed
}

modular-magician avatar Dec 18 '23 15:12 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 5 files changed, 1143 insertions(+), 2 deletions(-)) Terraform Beta: Diff ( 5 files changed, 1143 insertions(+), 2 deletions(-)) TF Conversion: Diff ( 1 file changed, 145 insertions(+))

modular-magician avatar Dec 18 '23 16:12 modular-magician

Tests analytics

Total tests: 3303 Passed tests 2965 Skipped tests: 337 Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccVertexAIFeatureGroup_vertexAiFeaturegroup_basic

Get to know how VCR tests work

modular-magician avatar Dec 18 '23 17:12 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccVertexAIFeatureGroup_vertexAiFeaturegroup_basic[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$ View the build log or the debug log for each test

modular-magician avatar Dec 18 '23 17:12 modular-magician

Can you please fix the failed test first, @kkram01 ? Thanks.

zli82016 avatar Dec 19 '23 16:12 zli82016

It looks like the resource is supported in another PR https://github.com/GoogleCloudPlatform/magic-modules/pull/9520

zli82016 avatar Dec 19 '23 22:12 zli82016

@kkram01, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

If no action is taken, this PR will be closed in 14 days.

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar May 29 '24 09:05 github-actions[bot]

@kkram01, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

If no action is taken, this PR will be closed in 2 weekdays.

This notification can be disabled with the disable-automatic-closure label.

github-actions[bot] avatar Jun 10 '24 09:06 github-actions[bot]

@kkram01, this PR is being closed due to inactivity.

github-actions[bot] avatar Jun 12 '24 09:06 github-actions[bot]