magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Fix broken links of provider.go.erb in "add / update resource" docs

Open grainrigi opened this issue 2 years ago • 18 comments

In "add / update resource" docs, links for provider.go.erb were broken so I fixed them.

If this PR is for Terraform, I acknowledge that I have:

  • [x] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [ ] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [ ] Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • [ ] Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [x] Read Write release notes before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


grainrigi avatar Aug 22 '23 12:08 grainrigi

Hello! I am a robot. It looks like you are a: Community Contributor ~Googler~ ~Core Contributor~. Tests will require approval to run.

@trodge, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician avatar Aug 22 '23 12:08 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

modular-magician avatar Aug 25 '23 20:08 modular-magician

Hi @trodge Can this please be merged? The documentation still sits out of date and incorrect

zachberger avatar Nov 10 '23 21:11 zachberger

This PR is approved and has been waiting for merge for 3 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar May 22 '24 09:05 github-actions[bot]

This PR is approved and has been waiting for merge for 4 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar May 29 '24 09:05 github-actions[bot]

This PR is approved and has been waiting for merge for 5 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 05 '24 09:06 github-actions[bot]

This PR is approved and has been waiting for merge for 6 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 12 '24 09:06 github-actions[bot]

This PR is approved and has been waiting for merge for 7 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 19 '24 09:06 github-actions[bot]

This PR is approved and has been waiting for merge for 8 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jun 26 '24 09:06 github-actions[bot]

This PR is approved and has been waiting for merge for 9 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jul 03 '24 09:07 github-actions[bot]

This PR is approved and has been waiting for merge for 10 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jul 10 '24 09:07 github-actions[bot]

This PR is approved and has been waiting for merge for 11 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jul 17 '24 09:07 github-actions[bot]

This PR is approved and has been waiting for merge for 12 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jul 24 '24 09:07 github-actions[bot]

This PR is approved and has been waiting for merge for 13 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Jul 31 '24 09:07 github-actions[bot]

This PR is approved and has been waiting for merge for 14 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Aug 07 '24 09:08 github-actions[bot]

This PR is approved and has been waiting for merge for 15 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Aug 14 '24 09:08 github-actions[bot]

This PR is approved and has been waiting for merge for 16 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Aug 21 '24 09:08 github-actions[bot]

This PR is approved and has been waiting for merge for 17 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Aug 28 '24 09:08 github-actions[bot]

This PR is approved and has been waiting for merge for 18 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

github-actions[bot] avatar Sep 04 '24 09:09 github-actions[bot]

Looks like this was fixed in the interim.

trodge avatar Sep 06 '24 21:09 trodge