magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard
verified publisher icon GoogleCloudPlatform

WIP: Add cloud_run_job resource

Open roaks3 opened this issue 3 years ago • 3 comments

NOTE: This is a draft only intended to share progress so far. This feature is still being discussed internally to determine the best path forward in terms of implementation and user experience.

The implementation here is a WIP of the Cloud Run Job resource using v1 of the API, and mmv1 to generate the resource.

b/240175294

If this PR is for Terraform, I acknowledge that I have:

  • [ ] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [ ] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [ ] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [ ] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [ ] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

roaks3 avatar Sep 15 '22 16:09 roaks3

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

modular-magician avatar Sep 15 '22 16:09 modular-magician

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @scottsuarez, a repository maintainer, has been assigned to assist you and help review your changes.

:question: First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.

modular-magician avatar Sep 15 '22 16:09 modular-magician

I notice this pr is in draft. Please comment when it is ready for review.

ScottSuarez avatar Sep 15 '22 17:09 ScottSuarez

Closing in favor of https://github.com/GoogleCloudPlatform/magic-modules/pull/6852 using v2 of the API

roaks3 avatar Nov 29 '22 21:11 roaks3