magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

vcr testing (should skip new vcr tests)

Open shuyama1 opened this issue 3 years ago • 20 comments

If this PR is for Terraform, I acknowledge that I have:

  • [ ] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [ ] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [ ] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [ ] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [ ] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


shuyama1 avatar Feb 14 '22 23:02 shuyama1

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+)) Terraform Beta: Diff ( 1 file changed, 4 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Feb 14 '22 23:02 modular-magician

/gcbrun

shuyama1 avatar Feb 14 '22 23:02 shuyama1

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+)) Terraform Beta: Diff ( 1 file changed, 4 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Feb 14 '22 23:02 modular-magician

/gcbrun

shuyama1 avatar Feb 15 '22 01:02 shuyama1

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+)) Terraform Beta: Diff ( 1 file changed, 4 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Feb 15 '22 01:02 modular-magician

/gcbrun

shuyama1 avatar Feb 15 '22 08:02 shuyama1

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+)) Terraform Beta: Diff ( 1 file changed, 4 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Feb 15 '22 09:02 modular-magician

/gcbrun

shuyama1 avatar Feb 15 '22 20:02 shuyama1

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+)) Terraform Beta: Diff ( 1 file changed, 4 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Feb 15 '22 20:02 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+)) Terraform Beta: Diff ( 1 file changed, 4 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Feb 15 '22 21:02 modular-magician

/gcbrun

shuyama1 avatar Feb 15 '22 21:02 shuyama1

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+)) Terraform Beta: Diff ( 1 file changed, 4 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Feb 15 '22 21:02 modular-magician

/gcbrun

shuyama1 avatar Feb 15 '22 22:02 shuyama1

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+)) Terraform Beta: Diff ( 1 file changed, 4 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Feb 15 '22 22:02 modular-magician

/gcbrun

shuyama1 avatar Feb 16 '22 00:02 shuyama1

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+)) Terraform Beta: Diff ( 1 file changed, 4 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Feb 16 '22 00:02 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+)) Terraform Beta: Diff ( 1 file changed, 4 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Feb 17 '22 23:02 modular-magician

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+)) Terraform Beta: Diff ( 1 file changed, 4 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Apr 01 '22 18:04 modular-magician

/gcbrun

shuyama1 avatar Apr 01 '22 18:04 shuyama1

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 4 insertions(+)) Terraform Beta: Diff ( 1 file changed, 4 insertions(+)) TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Apr 01 '22 18:04 modular-magician