magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Use id instead of self_link for vpc access connector

Open shuyama1 opened this issue 4 years ago • 5 comments

Update tests to use id not self_link for vpc access connector

If this PR is for Terraform, I acknowledge that I have:

  • [ ] Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • [ ] Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • [ ] Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • [ ] Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • [ ] Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


shuyama1 avatar Dec 22 '21 00:12 shuyama1

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-)) Terraform Beta: Diff ( 2 files changed, 19 insertions(+), 19 deletions(-))

modular-magician avatar Dec 22 '21 01:12 modular-magician

/gcbrun

shuyama1 avatar Dec 28 '21 18:12 shuyama1

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 23 insertions(+), 23 deletions(-)) Terraform Beta: Diff ( 2 files changed, 19 insertions(+), 19 deletions(-))

modular-magician avatar Dec 28 '21 19:12 modular-magician

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccContainerNodePool_withInvalidUpgradeSettings You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=237213

modular-magician avatar Dec 28 '21 21:12 modular-magician

Tests failed during RECORDING mode: TestAccContainerNodePool_withInvalidUpgradeSettings|TestAccApigeeEnvironmentIamBindingGenerated Please fix these to complete your PR

modular-magician avatar Dec 28 '21 21:12 modular-magician