Use a separate network in TestAccContainerCluster_networkingModeRoutes
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.
Fixes https://github.com/hashicorp/terraform-provider-google/issues/25084
Hello! I am a robot. Tests will require approval from a repository maintainer to run.
Googlers: For automatic test runs see go/terraform-auto-test-runs.
@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 1 file changed, 10 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 1 file changed, 10 insertions(+), 3 deletions(-))
Tests analytics
Total tests: 267 Passed tests: 251 Skipped tests: 11 Affected tests: 5
Click here to see the affected service packages
- container
Action taken
Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccContainerCluster_networkPerformanceConfig
- TestAccContainerCluster_networkingModeRoutes
- TestAccContainerCluster_withTPUConfig
- TestAccContainerCluster_withTpu
- TestAccContainerNodePool_secondaryBootDisks
🟢 Tests passed during RECORDING mode:
TestAccContainerCluster_networkingModeRoutes [Debug log]
🟢 No issues found for passed tests after REPLAYING rerun.
🔴 Tests failed during RECORDING mode:
TestAccContainerCluster_networkPerformanceConfig [Error message] [Debug log]
TestAccContainerCluster_withTPUConfig [Error message] [Debug log]
TestAccContainerCluster_withTpu [Error message] [Debug log]
TestAccContainerNodePool_secondaryBootDisks [Error message] [Debug log]
🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.
@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.
@GoogleCloudPlatform/terraform-team @SirGitsalot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.
@SirGitsalot This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.