magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Fix google_compute_interconnect to support the correct feature values

Open roaks3 opened this issue 1 year ago • 10 comments

Fixes https://github.com/hashicorp/terraform-provider-google/issues/19300

MACSEC is not a valid option, which causes an API error. This change adds the correct option (IF_MACSEC) so that it can be used instead, but we plan to keep the old option until the next major release to be safe.

Release Note Template for Downstream PRs (will be copied)

compute: fix `google_compute_interconnect` to support correct `available_features` option of `IF_MACSEC`

roaks3 avatar Aug 28 '24 20:08 roaks3

/gcbrun

roaks3 avatar Aug 28 '24 21:08 roaks3

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-)) google-beta provider: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

modular-magician avatar Aug 28 '24 21:08 modular-magician

Tests analytics

Total tests: 990 Passed tests: 912 Skipped tests: 77 Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceTemplate_withNamePrefix

Get to know how VCR tests work

modular-magician avatar Aug 28 '24 22:08 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccComputeInstanceTemplate_withNamePrefix[Debug log] $\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$ TestAccComputeInstanceTemplate_withNamePrefix[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

modular-magician avatar Aug 28 '24 22:08 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 8 insertions(+), 6 deletions(-)) google-beta provider: Diff ( 2 files changed, 8 insertions(+), 6 deletions(-))

modular-magician avatar Aug 29 '24 13:08 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 8 insertions(+), 6 deletions(-)) google-beta provider: Diff ( 2 files changed, 8 insertions(+), 6 deletions(-))

modular-magician avatar Aug 29 '24 13:08 modular-magician

Tests analytics

Total tests: 990 Passed tests: 912 Skipped tests: 77 Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceTemplate_withNamePrefix

Get to know how VCR tests work

modular-magician avatar Aug 29 '24 14:08 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccComputeInstanceTemplate_withNamePrefix[Debug log] $\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$ TestAccComputeInstanceTemplate_withNamePrefix[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

modular-magician avatar Aug 29 '24 14:08 modular-magician

Tests analytics

Total tests: 990 Passed tests: 912 Skipped tests: 77 Affected tests: 1

Click here to see the affected service packages
  • compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeInstanceTemplate_withNamePrefix

Get to know how VCR tests work

modular-magician avatar Aug 29 '24 14:08 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccComputeInstanceTemplate_withNamePrefix[Debug log] $\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$ TestAccComputeInstanceTemplate_withNamePrefix[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

modular-magician avatar Aug 29 '24 14:08 modular-magician