GoogleCloudPlatform
Add PUPI import and export to google_compute_network_peering_routes_config
This PR adds the import_subnet_routes_with_public_ip and export_subnet_routes_with_public_ip fields to the compute resource google_compute_network_peering_routes_config.
Fixes: https://github.com/hashicorp/terraform-provider-google/issues/11573
Although there is an API side default, I set these fields as required without defaults as people may have this resource already in state, and it is undesirable to change without explicitly choosing to.
This mirrors the approach of import_custom_routes and export_custom_routes. Please let me know if there is a better approach.
Release Note Template for Downstream PRs (will be copied)
compute: added `import_subnet_routes_with_public_ip` field to `google_compute_network_peering_routes_config` resource
compute: added `export_subnet_routes_with_public_ip` field to `google_compute_network_peering_routes_config` resource
Hello! I am a robot. Tests will require approval from a repository maintainer to run.
@shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 78 insertions(+))
google-beta provider: Diff ( 3 files changed, 78 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 2 insertions(+))
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 76 insertions(+))
google-beta provider: Diff ( 3 files changed, 76 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 2 insertions(+))
Tests analytics
Total tests: 982 Passed tests: 906 Skipped tests: 72 Affected tests: 4
Click here to see the affected service packages
- compute
Action taken
Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccComputeDisk_storagePoolSpecified
- TestAccComputeInstance_bootDisk_storagePoolSpecified
- TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigBasicExample
- TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample
Get to know how VCR tests work
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeDisk_storagePoolSpecified[Error message] [Debug log]
TestAccComputeInstance_bootDisk_storagePoolSpecified[Error message] [Debug log]
TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigBasicExample[Error message] [Debug log]
TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample[Error message] [Debug log]
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log or the debug log for each test
Tests analytics
Total tests: 982 Passed tests: 906 Skipped tests: 72 Affected tests: 4
Click here to see the affected service packages
- compute
Action taken
Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccComputeDisk_storagePoolSpecified
- TestAccComputeInstance_bootDisk_storagePoolSpecified
- TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigBasicExample
- TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample
Get to know how VCR tests work
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeDisk_storagePoolSpecified[Error message] [Debug log]
TestAccComputeInstance_bootDisk_storagePoolSpecified[Error message] [Debug log]
TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigBasicExample[Error message] [Debug log]
TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigGkeExample[Error message] [Debug log]
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 78 insertions(+))
google-beta provider: Diff ( 3 files changed, 78 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 2 insertions(+))
Tests analytics
Total tests: 988 Passed tests: 910 Skipped tests: 77 Affected tests: 1
Click here to see the affected service packages
- compute
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigBasicExample
Get to know how VCR tests work
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigBasicExample[Error message] [Debug log]
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log or the debug log for each test
@benjamin-maynard, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.
If no action is taken, this PR will be closed in 28 days.
This notification can be disabled with the disable-automatic-closure label.
Sorry for missing this PR on my review list. Taking a look now.
/gcbrun for triggering a new presubmit run
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 78 insertions(+))
google-beta provider: Diff ( 3 files changed, 78 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 2 insertions(+))
Tests analytics
Total tests: 997 Passed tests: 920 Skipped tests: 76 Affected tests: 1
Click here to see the affected service packages
- compute
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigBasicExample
Get to know how VCR tests work
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigBasicExample[Error message] [Debug log]
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log or the debug log for each test
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 3 files changed, 78 insertions(+))
google-beta provider: Diff ( 3 files changed, 78 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 20 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 2 insertions(+))
Tests analytics
Total tests: 1004 Passed tests: 929 Skipped tests: 74 Affected tests: 1
Click here to see the affected service packages
- compute
Action taken
Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
- TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigBasicExample
Get to know how VCR tests work
$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeNetworkPeeringRoutesConfig_networkPeeringRoutesConfigBasicExample[Error message] [Debug log]
$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log or the debug log for each test
@benjamin-maynard, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.
If no action is taken, this PR will be closed in 14 days.
This notification can be disabled with the disable-automatic-closure label.
Hi @benjamin-maynard
Tomorrow, the Magic Modules repository is scheduled to undergo a language migration from Ruby to Go. You can view more details about this in our announcement here: https://github.com/hashicorp/terraform-provider-google/issues/19583 (or go/mm-migration-announcement if you are a Googler)
This open pull request may become incompatible due to most YAML and .erb files converting to Go-compatible files.
Our team (Magic Modules repository maintainers) has tooling to automatically convert changes to the new language, and we can prepare a new commit for this pull request that is compatible with the migration.
In order to push the new changes to your pull request, we would need to force push the commit to your fork's branch. Our tooling saves a backup branch before converting, so we could rollback or open a new pull request if needed. We would also work with you and the PR reviewer in the event additional changes are needed.
You also have the option to update the pull request yourself after the migration. You can view a preview branch and updated documentation related to the migration changes.
We will take no action until we have your explicit permission to push changes to your fork's branch used for this pull request. Let me or your reviewer know if you have any further questions!
@benjamin-maynard, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.
If no action is taken, this PR will be closed in 2 weekdays.
This notification can be disabled with the disable-automatic-closure label.