magic-modules [WIP] Add support for sql_network_architecture in CloudSQL instances

For https://github.com/hashicorp/terraform-provider-google/issues/17552 .

At this time, this patch submits the following request to the endpoint,

{
  "databaseVersion": "MYSQL_8_0",
  "name": "api-test-1h0bto0bma",
  "region": "us-central1",
  "settings": {
    "activationPolicy": "ALWAYS",
    "availabilityType": "ZONAL",
    "dataDiskType": "PD_SSD",
    "edition": "ENTERPRISE",
    "enableGoogleMlIntegration": false,
    "pricingPlan": "PER_USE",
    "storageAutoResize": true,
    "tier": "db-g1-small"
  },
  "sqlNetworkArchitecture": "OLD_NETWORK_ARCHITECTURE"
}

however, results in an instance with NEW_NETWORK_ARCHITECTURE instead of OLD_NETWORK_ARCHITECTURE, without error.

s2@cloudshell:~ (s2tfdev-able-goat)$ gcloud sql instances describe api-test-1h0bto0bma | grep sqlNetworkArchitecture:
sqlNetworkArchitecture: NEW_NETWORK_ARCHITECTURE

This makes it impossible to build an instance that works with the old network architecture, causing tests to fail. Without a way to create Cloud SQL instances with the old network architecture, we are unable to implement a working test, so this patch cannot be merged at this time.

Release Note Template for Downstream PRs (will be copied)

Add support for sql_network_architecture in CloudSQL instances

Jul 26 '24 15:07 marblejenka

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Jul 26 '24 15:07 github-actions[bot]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 79 insertions(+), 5 deletions(-)) google-beta provider: Diff ( 2 files changed, 79 insertions(+), 5 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_sql_database_instance (125 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_sql_database_instance" "primary" {
  sql_network_architecture = # value needed
}

Jul 26 '24 15:07 modular-magician

Tests analytics

Total tests: 96 Passed tests: 5 Skipped tests: 14 Affected tests: 77

Click here to see the affected service packages

sql

Action taken

Found 77 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceGoogleSQLCaCerts_basic

TestAccDataSourceSqlDatabaseInstanceLatestRecoveryTime_basic

TestAccDataSourceSqlDatabaseInstance_basic

TestAccDataSourceSqlDatabaseInstances_basic

TestAccDataSourceSqlDatabaseInstances_databaseVersionFilter

TestAccDataSourceSqlDatabaseInstances_regionFilter

TestAccDataSourceSqlDatabaseInstances_tierFilter

TestAccDataSourceSqlDatabase_basic

TestAccDataSourceSqlDatabases_basic

TestAccSQLDatabaseInstance_DenyMaintenancePeriod

TestAccSQLDatabaseInstance_sqlMysqlDataCacheConfig

TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig

TestAccSQLDatabase_sqlDatabaseBasicExample

TestAccSQLDatabase_sqlDatabaseDeletionPolicyExample

TestAccSqlClientCert_mysql

TestAccSqlClientCert_postgres

TestAccSqlDatabaseInstance_BackupRetention

TestAccSqlDatabaseInstance_Edition

TestAccSqlDatabaseInstance_Edition_Downgrade

TestAccSqlDatabaseInstance_EnableGoogleDataplexIntegration

TestAccSqlDatabaseInstance_EnableGoogleMlIntegration

TestAccSqlDatabaseInstance_Mysql_Edition_Upgrade

TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled

TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer

TestAccSqlDatabaseInstance_Postgres_Edition_Upgrade

TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithMasterInstanceNameAndReplicaConfigurationPresent

TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithMasterInstanceNamePresent

TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithReplicaConfigurationPresent

TestAccSqlDatabaseInstance_ReplicaPromoteSkippedWithNoMasterInstanceNameAndNoReplicaConfigurationPresent

TestAccSqlDatabaseInstance_ReplicaPromoteSuccessful

TestAccSqlDatabaseInstance_Smt

TestAccSqlDatabaseInstance_SqlServerAuditOptionalBucket

TestAccSqlDatabaseInstance_Timezone

TestAccSqlDatabaseInstance_activationPolicy

TestAccSqlDatabaseInstance_authNets

TestAccSqlDatabaseInstance_basicInstance_thenPSCEnabled

TestAccSqlDatabaseInstance_basicMSSQL

TestAccSqlDatabaseInstance_basicSecondGen

TestAccSqlDatabaseInstance_basic_with_user_labels

TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls

TestAccSqlDatabaseInstance_diskspecs

TestAccSqlDatabaseInstance_dontDeleteDefaultUserOnReplica

TestAccSqlDatabaseInstance_encryptionKey

TestAccSqlDatabaseInstance_encryptionKey_replicaInDifferentRegion

TestAccSqlDatabaseInstance_highAvailability

TestAccSqlDatabaseInstance_insights

TestAccSqlDatabaseInstance_maintenance

TestAccSqlDatabaseInstance_maintenanceVersion

TestAccSqlDatabaseInstance_maintenance_update_track_week5

TestAccSqlDatabaseInstance_multipleOperations

TestAccSqlDatabaseInstance_networkArchitecture

TestAccSqlDatabaseInstance_replica

TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable

TestAccSqlDatabaseInstance_settingsDowngrade

TestAccSqlDatabaseInstance_settings_basic

TestAccSqlDatabaseInstance_settings_deletionProtection

TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled

TestAccSqlDatabaseInstance_settings_secondary

TestAccSqlDatabaseInstance_settings_upgrade

TestAccSqlDatabaseInstance_slave

TestAccSqlDatabaseInstance_sqlMysqlInstancePvpExample

TestAccSqlDatabaseInstance_updateDifferentFlagOrder

TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled

TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL

TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject

TestAccSqlDatabaseInstance_withPSCEnabled_withAllowedConsumerProjects

TestAccSqlDatabaseInstance_withPSCEnabled_withEmptyAllowedConsumerProjects

TestAccSqlDatabaseInstance_withPSCEnabled_withoutAllowedConsumerProjects

TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange

TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone

TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica

TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange

TestAccSqlDatabase_basic

TestAccSqlDatabase_update

TestAccSqlUser_postgres

TestAccSqlUser_postgresAbandon

TestAccSqlUser_postgresIAM

Get to know how VCR tests work

Jul 26 '24 15:07 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccDataSourceGoogleSQLCaCerts_basic[Error message] [Debug log] TestAccDataSourceSqlDatabaseInstanceLatestRecoveryTime_basic[Error message] [Debug log] TestAccDataSourceSqlDatabaseInstance_basic[Error message] [Debug log] TestAccDataSourceSqlDatabaseInstances_basic[Error message] [Debug log] TestAccDataSourceSqlDatabaseInstances_databaseVersionFilter[Error message] [Debug log] TestAccDataSourceSqlDatabaseInstances_regionFilter[Error message] [Debug log] TestAccDataSourceSqlDatabaseInstances_tierFilter[Error message] [Debug log] TestAccDataSourceSqlDatabase_basic[Error message] [Debug log] TestAccDataSourceSqlDatabases_basic[Error message] [Debug log] TestAccSQLDatabaseInstance_DenyMaintenancePeriod[Error message] [Debug log] TestAccSQLDatabaseInstance_sqlMysqlDataCacheConfig[Error message] [Debug log] TestAccSQLDatabaseInstance_sqlPostgresDataCacheConfig[Error message] [Debug log] TestAccSQLDatabase_sqlDatabaseBasicExample[Error message] [Debug log] TestAccSQLDatabase_sqlDatabaseDeletionPolicyExample[Error message] [Debug log] TestAccSqlClientCert_mysql[Error message] [Debug log] TestAccSqlClientCert_postgres[Error message] [Debug log] TestAccSqlDatabaseInstance_BackupRetention[Error message] [Debug log] TestAccSqlDatabaseInstance_Edition[Error message] [Debug log] TestAccSqlDatabaseInstance_Edition_Downgrade[Error message] [Debug log] TestAccSqlDatabaseInstance_EnableGoogleDataplexIntegration[Error message] [Debug log] TestAccSqlDatabaseInstance_EnableGoogleMlIntegration[Error message] [Debug log] TestAccSqlDatabaseInstance_Mysql_Edition_Upgrade[Error message] [Debug log] TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled[Error message] [Debug log] TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer[Error message] [Debug log] TestAccSqlDatabaseInstance_Postgres_Edition_Upgrade[Error message] [Debug log] TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithMasterInstanceNameAndReplicaConfigurationPresent[Error message] [Debug log] TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithMasterInstanceNamePresent[Error message] [Debug log] TestAccSqlDatabaseInstance_ReplicaPromoteFailedWithReplicaConfigurationPresent[Error message] [Debug log] TestAccSqlDatabaseInstance_ReplicaPromoteSkippedWithNoMasterInstanceNameAndNoReplicaConfigurationPresent[Error message] [Debug log] TestAccSqlDatabaseInstance_ReplicaPromoteSuccessful[Error message] [Debug log] TestAccSqlDatabaseInstance_Smt[Error message] [Debug log] TestAccSqlDatabaseInstance_SqlServerAuditOptionalBucket[Error message] [Debug log] TestAccSqlDatabaseInstance_Timezone[Error message] [Debug log] TestAccSqlDatabaseInstance_activationPolicy[Error message] [Debug log] TestAccSqlDatabaseInstance_authNets[Error message] [Debug log] TestAccSqlDatabaseInstance_basicInstance_thenPSCEnabled[Error message] [Debug log] TestAccSqlDatabaseInstance_basicMSSQL[Error message] [Debug log] TestAccSqlDatabaseInstance_basicSecondGen[Error message] [Debug log] TestAccSqlDatabaseInstance_basic_with_user_labels[Error message] [Debug log] TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls[Error message] [Debug log] TestAccSqlDatabaseInstance_diskspecs[Error message] [Debug log] TestAccSqlDatabaseInstance_dontDeleteDefaultUserOnReplica[Error message] [Debug log] TestAccSqlDatabaseInstance_encryptionKey[Error message] [Debug log] TestAccSqlDatabaseInstance_encryptionKey_replicaInDifferentRegion[Error message] [Debug log] TestAccSqlDatabaseInstance_highAvailability[Error message] [Debug log] TestAccSqlDatabaseInstance_insights[Error message] [Debug log] TestAccSqlDatabaseInstance_maintenance[Error message] [Debug log] TestAccSqlDatabaseInstance_maintenanceVersion[Error message] [Debug log] TestAccSqlDatabaseInstance_maintenance_update_track_week5[Error message] [Debug log] TestAccSqlDatabaseInstance_multipleOperations[Error message] [Debug log] TestAccSqlDatabaseInstance_networkArchitecture[Error message] [Debug log] TestAccSqlDatabaseInstance_replica[Error message] [Debug log] TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable[Error message] [Debug log] TestAccSqlDatabaseInstance_settingsDowngrade[Error message] [Debug log] TestAccSqlDatabaseInstance_settings_basic[Error message] [Debug log] TestAccSqlDatabaseInstance_settings_deletionProtection[Error message] [Debug log] TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled[Error message] [Debug log] TestAccSqlDatabaseInstance_settings_secondary[Error message] [Debug log] TestAccSqlDatabaseInstance_settings_upgrade[Error message] [Debug log] TestAccSqlDatabaseInstance_slave[Error message] [Debug log] TestAccSqlDatabaseInstance_sqlMysqlInstancePvpExample[Error message] [Debug log] TestAccSqlDatabaseInstance_updateDifferentFlagOrder[Error message] [Debug log] TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled[Error message] [Debug log] TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL[Error message] [Debug log] TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject[Error message] [Debug log] TestAccSqlDatabaseInstance_withPSCEnabled_withAllowedConsumerProjects[Error message] [Debug log] TestAccSqlDatabaseInstance_withPSCEnabled_withEmptyAllowedConsumerProjects[Error message] [Debug log] TestAccSqlDatabaseInstance_withPSCEnabled_withoutAllowedConsumerProjects[Error message] [Debug log] TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[Error message] [Debug log] TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeClone[Error message] [Debug log] TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRangeReplica[Error message] [Debug log] TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange[Error message] [Debug log] TestAccSqlDatabase_basic[Error message] [Debug log] TestAccSqlDatabase_update[Error message] [Debug log] TestAccSqlUser_postgres[Error message] [Debug log] TestAccSqlUser_postgresAbandon[Error message] [Debug log] TestAccSqlUser_postgresIAM[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Jul 26 '24 16:07 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 79 insertions(+), 6 deletions(-)) google-beta provider: Diff ( 2 files changed, 79 insertions(+), 6 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_sql_database_instance (125 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_sql_database_instance" "primary" {
  sql_network_architecture = # value needed
}

Aug 16 '24 00:08 modular-magician

Tests analytics

Total tests: 97 Passed tests: 55 Skipped tests: 14 Affected tests: 28

Click here to see the affected service packages

sql

Action taken

Found 28 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceSqlDatabaseInstances_basic

TestAccDataSourceSqlDatabaseInstances_databaseVersionFilter

TestAccDataSourceSqlDatabaseInstances_regionFilter

TestAccDataSourceSqlDatabaseInstances_tierFilter

TestAccSqlDatabaseInstance_Edition_Downgrade

TestAccSqlDatabaseInstance_EnableGoogleDataplexIntegration

TestAccSqlDatabaseInstance_EnableGoogleMlIntegration

TestAccSqlDatabaseInstance_Mysql_Edition_Upgrade

TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled

TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer

TestAccSqlDatabaseInstance_Postgres_Edition_Upgrade

TestAccSqlDatabaseInstance_Smt

TestAccSqlDatabaseInstance_activationPolicy

TestAccSqlDatabaseInstance_authNets

TestAccSqlDatabaseInstance_basicInstance_thenPSCEnabled

TestAccSqlDatabaseInstance_basicMSSQL

TestAccSqlDatabaseInstance_basic_with_user_labels

TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls

TestAccSqlDatabaseInstance_networkArchitecture

TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable

TestAccSqlDatabaseInstance_settings_deletionProtection

TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled

TestAccSqlDatabaseInstance_settings_upgrade

TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled

TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL

TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject

TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange

TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange

Get to know how VCR tests work

Aug 16 '24 00:08 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccSqlDatabaseInstance_Edition_Downgrade[Debug log] TestAccSqlDatabaseInstance_EnableGoogleDataplexIntegration[Debug log] TestAccSqlDatabaseInstance_EnableGoogleMlIntegration[Debug log] TestAccSqlDatabaseInstance_Mysql_Edition_Upgrade[Debug log] TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabled[Debug log] TestAccSqlDatabaseInstance_PointInTimeRecoveryEnabledForSqlServer[Debug log] TestAccSqlDatabaseInstance_Postgres_Edition_Upgrade[Debug log] TestAccSqlDatabaseInstance_Smt[Debug log] TestAccSqlDatabaseInstance_activationPolicy[Debug log] TestAccSqlDatabaseInstance_authNets[Debug log] TestAccSqlDatabaseInstance_basicInstance_thenPSCEnabled[Debug log] TestAccSqlDatabaseInstance_basicMSSQL[Debug log] TestAccSqlDatabaseInstance_basic_with_user_labels[Debug log] TestAccSqlDatabaseInstance_deleteDefaultUserBeforeSubsequentApiCalls[Debug log] TestAccSqlDatabaseInstance_rootPasswordShouldBeUpdatable[Debug log] TestAccSqlDatabaseInstance_settings_deletionProtection[Debug log] TestAccSqlDatabaseInstance_settings_deletionProtectionEnabled[Debug log] TestAccSqlDatabaseInstance_settings_upgrade[Debug log] TestAccSqlDatabaseInstance_updateReadReplicaWithBinaryLogEnabled[Debug log] TestAccSqlDatabaseInstance_updateSslOptionsForPostgreSQL[Debug log] TestAccSqlDatabaseInstance_withPSCEnabled_thenAddAllowedConsumerProjects_thenRemoveAllowedConsumerProject[Debug log] TestAccSqlDatabaseInstance_withPrivateNetwork_withAllocatedIpRange[Debug log] TestAccSqlDatabaseInstance_withPrivateNetwork_withoutAllocatedIpRange[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccDataSourceSqlDatabaseInstances_basic[Error message] [Debug log] TestAccDataSourceSqlDatabaseInstances_databaseVersionFilter[Error message] [Debug log] TestAccDataSourceSqlDatabaseInstances_regionFilter[Error message] [Debug log] TestAccDataSourceSqlDatabaseInstances_tierFilter[Error message] [Debug log] TestAccSqlDatabaseInstance_networkArchitecture[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Aug 16 '24 00:08 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 100 insertions(+), 6 deletions(-)) google-beta provider: Diff ( 2 files changed, 100 insertions(+), 6 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_sql_database_instance (125 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_sql_database_instance" "primary" {
  sql_network_architecture = # value needed
}

Aug 16 '24 01:08 modular-magician

Tests analytics

Total tests: 97 Passed tests: 78 Skipped tests: 14 Affected tests: 5

Click here to see the affected service packages

sql

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceSqlDatabaseInstances_basic

TestAccDataSourceSqlDatabaseInstances_databaseVersionFilter

TestAccDataSourceSqlDatabaseInstances_regionFilter

TestAccDataSourceSqlDatabaseInstances_tierFilter

TestAccSqlDatabaseInstance_networkArchitecture

Get to know how VCR tests work

Aug 16 '24 01:08 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccDataSourceSqlDatabaseInstances_basic[Error message] [Debug log] TestAccDataSourceSqlDatabaseInstances_databaseVersionFilter[Error message] [Debug log] TestAccDataSourceSqlDatabaseInstances_regionFilter[Error message] [Debug log] TestAccDataSourceSqlDatabaseInstances_tierFilter[Error message] [Debug log] TestAccSqlDatabaseInstance_networkArchitecture[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Aug 16 '24 01:08 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 102 insertions(+), 6 deletions(-)) google-beta provider: Diff ( 2 files changed, 102 insertions(+), 6 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_sql_database_instance (125 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_sql_database_instance" "primary" {
  sql_network_architecture = # value needed
}

Aug 16 '24 01:08 modular-magician

Tests analytics

Total tests: 97 Passed tests: 78 Skipped tests: 14 Affected tests: 5

Click here to see the affected service packages

sql

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccDataSourceSqlDatabaseInstances_basic

TestAccDataSourceSqlDatabaseInstances_databaseVersionFilter

TestAccDataSourceSqlDatabaseInstances_regionFilter

TestAccDataSourceSqlDatabaseInstances_tierFilter

TestAccSqlDatabaseInstance_networkArchitecture

Get to know how VCR tests work

Aug 16 '24 01:08 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccDataSourceSqlDatabaseInstances_basic[Error message] [Debug log] TestAccDataSourceSqlDatabaseInstances_databaseVersionFilter[Error message] [Debug log] TestAccDataSourceSqlDatabaseInstances_regionFilter[Error message] [Debug log] TestAccDataSourceSqlDatabaseInstances_tierFilter[Error message] [Debug log] TestAccSqlDatabaseInstance_networkArchitecture[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Aug 16 '24 02:08 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 114 insertions(+), 14 deletions(-)) google-beta provider: Diff ( 3 files changed, 114 insertions(+), 14 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_sql_database_instance (125 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_sql_database_instance" "primary" {
  sql_network_architecture = # value needed
}

Aug 16 '24 03:08 modular-magician

Tests analytics

Total tests: 97 Passed tests: 82 Skipped tests: 14 Affected tests: 1

Click here to see the affected service packages

sql

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSqlDatabaseInstance_networkArchitecture

Get to know how VCR tests work

Aug 16 '24 03:08 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccSqlDatabaseInstance_networkArchitecture[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Aug 16 '24 03:08 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 114 insertions(+), 14 deletions(-)) google-beta provider: Diff ( 3 files changed, 114 insertions(+), 14 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_sql_database_instance (125 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_sql_database_instance" "primary" {
  sql_network_architecture = # value needed
}

Aug 16 '24 03:08 modular-magician

Tests analytics

Total tests: 97 Passed tests: 82 Skipped tests: 14 Affected tests: 1

Click here to see the affected service packages

sql

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSqlDatabaseInstance_networkArchitecture

Get to know how VCR tests work

Aug 16 '24 03:08 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccSqlDatabaseInstance_networkArchitecture[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Aug 16 '24 03:08 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 145 insertions(+), 14 deletions(-)) google-beta provider: Diff ( 3 files changed, 145 insertions(+), 14 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_sql_database_instance (125 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_sql_database_instance" "primary" {
  sql_network_architecture = # value needed
}

Aug 16 '24 03:08 modular-magician

Tests analytics

Total tests: 97 Passed tests: 82 Skipped tests: 14 Affected tests: 1

Click here to see the affected service packages

sql

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSqlDatabaseInstance_networkArchitecture

Get to know how VCR tests work

Aug 16 '24 04:08 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccSqlDatabaseInstance_networkArchitecture[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Aug 16 '24 04:08 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 113 insertions(+), 14 deletions(-)) google-beta provider: Diff ( 3 files changed, 113 insertions(+), 14 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_sql_database_instance (125 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_sql_database_instance" "primary" {
  sql_network_architecture = # value needed
}

Aug 16 '24 11:08 modular-magician

Tests analytics

Total tests: 97 Passed tests: 82 Skipped tests: 14 Affected tests: 1

Click here to see the affected service packages

sql

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSqlDatabaseInstance_networkArchitecture

Get to know how VCR tests work

Aug 16 '24 11:08 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccSqlDatabaseInstance_networkArchitecture[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Aug 16 '24 11:08 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 121 insertions(+), 14 deletions(-)) google-beta provider: Diff ( 3 files changed, 121 insertions(+), 14 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_sql_database_instance (125 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_sql_database_instance" "primary" {
  sql_network_architecture = # value needed
}

Aug 16 '24 11:08 modular-magician

Tests analytics

Total tests: 97 Passed tests: 82 Skipped tests: 14 Affected tests: 1

Click here to see the affected service packages

sql

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSqlDatabaseInstance_networkArchitecture

Get to know how VCR tests work

Aug 16 '24 11:08 modular-magician

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccSqlDatabaseInstance_networkArchitecture[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

Aug 16 '24 11:08 modular-magician

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 121 insertions(+), 14 deletions(-)) google-beta provider: Diff ( 3 files changed, 121 insertions(+), 14 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_sql_database_instance (125 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_sql_database_instance" "primary" {
  sql_network_architecture = # value needed
}

Aug 16 '24 11:08 modular-magician

Tests analytics

Total tests: 97 Passed tests: 82 Skipped tests: 14 Affected tests: 1

Click here to see the affected service packages

sql

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSqlDatabaseInstance_networkArchitecture

Get to know how VCR tests work

Aug 16 '24 12:08 modular-magician