magic-modules icon indicating copy to clipboard operation
magic-modules copied to clipboard

Sync main feature branch 6.0.0 - 7/1

Open c2thorn opened this issue 1 year ago • 3 comments

Release Note Template for Downstream PRs (will be copied)


c2thorn avatar Jul 01 '24 17:07 c2thorn

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 142 files changed, 7330 insertions(+), 1313 deletions(-)) google-beta provider: Diff ( 150 files changed, 7556 insertions(+), 1317 deletions(-)) terraform-google-conversion: Diff ( 28 files changed, 2170 insertions(+), 10 deletions(-)) Open in Cloud Shell: Diff ( 16 files changed, 458 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

  • Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer. If you intend to make this change you will need to wait for a major release window. An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_compute_region_url_map (44 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_url_map" "primary" {
  path_matcher {
    route_rules {
      route_action {
        retry_policy {
          retry_conditions = # value needed
        }
      }
    }
  }
}


Resource: google_compute_url_map (66 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_url_map" "primary" {
  path_matcher {
    route_rules {
      route_action {
        retry_policy {
          retry_conditions = # value needed
        }
      }
    }
  }
}


Resource: google_secure_source_manager_repository_iam_binding (2 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_repository_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}


Resource: google_secure_source_manager_repository_iam_member (1 total tests) Please add an acceptance test which includes these fields. The test should include the following:

resource "google_secure_source_manager_repository_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}


modular-magician avatar Jul 01 '24 18:07 modular-magician

Tests analytics

Total tests: 3837 Passed tests: 3425 Skipped tests: 378 Affected tests: 34

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccStorageManagedFolderIamBindingGenerated_withAndWithoutCondition
  • TestAccStorageManagedFolderIamMemberGenerated_withAndWithoutCondition
  • TestUnitCloudSchedulerJob_LastSlashDiffSuppress
  • TestUnitComputeGlobalForwardingRule_InternalIpDiffSuppress
  • TestUnitComputeGlobalForwardingRule_PortRangeDiffSuppress
  • TestUnitComputeInstanceTemplate_IpCidrRangeDiffSuppress
  • TestUnitComputeManagedSslCertificate_AbsoluteDomainSuppress
  • TestUnitContainerCluster_Rfc3339TimeDiffSuppress
  • TestUnitLoggingFolder_OptionalPrefixSuppress
  • TestUnitLoggingSink_OptionalSurroundingSpacesSuppress
  • TestUnitPubsubSubscription_IgnoreMissingKeyInMap

Action taken

Found 34 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccAppEngineFlexibleAppVersion_update
  • TestAccBigqueryReservationReservationAssignment_bigqueryReservationAssignmentBasicExample
  • TestAccBigqueryReservationReservationAssignment_bigqueryReservationAssignmentFullExample
  • TestAccCertificateManagerTrustConfig_certificateManagerTrustConfigAllowlistedCertificatesExample
  • TestAccCertificateManagerTrustConfig_update
  • TestAccComputeHealthCheck_srcRegions_update
  • TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
  • TestAccDataSourceGoogleKmsCryptoKeys_basic
  • TestAccDataSourceGoogleKmsKeyRings_basic
  • TestAccDataplexDatascan_dataplexDatascanFullQualityExample
  • TestAccMonitoringAlertPolicy
  • TestAccNetappstoragePool_FlexRegionalStoragePoolCreateExample_update
  • TestAccSecureSourceManagerRepositoryIamBindingGenerated
  • TestAccSecureSourceManagerRepositoryIamMemberGenerated
  • TestAccSecureSourceManagerRepositoryIamPolicyGenerated
  • TestAccSecureSourceManagerRepository_secureSourceManagerRepositoryBasicExample
  • TestAccSecureSourceManagerRepository_secureSourceManagerRepositoryInitialConfigExample
  • TestAccSecurityCenterV2OrganizationNotificationConfig_basic
  • TestAccSecurityCenterV2OrganizationNotificationConfig_sccV2OrganizationNotificationConfigBasicExample
  • TestAccStorageManagedFolderIamBindingGenerated
  • TestAccStorageManagedFolderIamBindingGenerated_withCondition
  • TestAccStorageManagedFolderIamMemberGenerated
  • TestAccStorageManagedFolderIamMemberGenerated_withCondition
  • TestAccStorageManagedFolderIamPolicyGenerated
  • TestAccStorageManagedFolderIamPolicyGenerated_withCondition
  • TestAccStorageManagedFolder_storageManagedFolderBasicExample
  • TestAccVPCAccessConnectorDatasource_basic
  • TestAccWorkstationsWorkstationConfigIamBindingGenerated
  • TestAccWorkstationsWorkstationConfigIamMemberGenerated
  • TestAccWorkstationsWorkstationConfigIamPolicyGenerated
  • TestAccWorkstationsWorkstationConfig_update
  • TestAccWorkstationsWorkstationConfig_updateHostDetails
  • TestAccWorkstationsWorkstationConfig_vmTags
  • TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample

Get to know how VCR tests work

modular-magician avatar Jul 01 '24 19:07 modular-magician

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$ TestAccBigqueryReservationReservationAssignment_bigqueryReservationAssignmentBasicExample[Debug log] TestAccBigqueryReservationReservationAssignment_bigqueryReservationAssignmentFullExample[Debug log] TestAccCertificateManagerTrustConfig_certificateManagerTrustConfigAllowlistedCertificatesExample[Debug log] TestAccCertificateManagerTrustConfig_update[Debug log] TestAccComputeHealthCheck_srcRegions_update[Debug log] TestAccDataSourceGoogleKmsCryptoKeys_basic[Debug log] TestAccDataplexDatascan_dataplexDatascanFullQualityExample[Debug log] TestAccMonitoringAlertPolicy[Debug log] TestAccNetappstoragePool_FlexRegionalStoragePoolCreateExample_update[Debug log] TestAccSecureSourceManagerRepositoryIamBindingGenerated[Debug log] TestAccSecureSourceManagerRepositoryIamMemberGenerated[Debug log] TestAccSecureSourceManagerRepositoryIamPolicyGenerated[Debug log] TestAccSecureSourceManagerRepository_secureSourceManagerRepositoryBasicExample[Debug log] TestAccSecureSourceManagerRepository_secureSourceManagerRepositoryInitialConfigExample[Debug log] TestAccSecurityCenterV2OrganizationNotificationConfig_basic[Debug log] TestAccSecurityCenterV2OrganizationNotificationConfig_sccV2OrganizationNotificationConfigBasicExample[Debug log] TestAccStorageManagedFolderIamBindingGenerated[Debug log] TestAccStorageManagedFolderIamBindingGenerated_withCondition[Debug log] TestAccStorageManagedFolderIamMemberGenerated[Debug log] TestAccStorageManagedFolderIamMemberGenerated_withCondition[Debug log] TestAccStorageManagedFolderIamPolicyGenerated[Debug log] TestAccStorageManagedFolderIamPolicyGenerated_withCondition[Debug log] TestAccStorageManagedFolder_storageManagedFolderBasicExample[Debug log] TestAccVPCAccessConnectorDatasource_basic[Debug log] TestAccWorkstationsWorkstationConfigIamBindingGenerated[Debug log] TestAccWorkstationsWorkstationConfigIamMemberGenerated[Debug log] TestAccWorkstationsWorkstationConfigIamPolicyGenerated[Debug log] TestAccWorkstationsWorkstationConfig_update[Debug log] TestAccWorkstationsWorkstationConfig_updateHostDetails[Debug log] TestAccWorkstationsWorkstationConfig_vmTags[Debug log] TestAccWorkstationsWorkstationConfig_workstationConfigBasicExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$ TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log] TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log] TestAccDataSourceGoogleKmsKeyRings_basic[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

modular-magician avatar Jul 01 '24 20:07 modular-magician

Thanks for making the sync PR. Both TestAccAppEngineFlexibleAppVersion_update and TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy are known issues. Can we also confirm TestAccDataSourceGoogleKmsKeyRings_basic failure is not related? Thanks!

Ran TestAccDataSourceGoogleKmsKeyRings_basic in MM Upstream TC and it passed

c2thorn avatar Jul 02 '24 16:07 c2thorn