GoogleCloudPlatform
added required label to load balancing scheme for traffic extensions
Fixes: https://github.com/hashicorp/terraform-provider-google/issues/18196
Release Note Template for Downstream PRs (will be copied)
networkservices: made field `load_balancing_scheme` required in resource `google_network_services_lb_traffic_extension`, as resource creation is always failing
References
- https://cloud.google.com/service-extensions/docs/reference/rest/v1beta1/projects.locations.lbTrafficExtensions#resource:-lbtrafficextension
Hello! I am a robot. Tests will require approval from a repository maintainer to run.
@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.
You can help make sure that review is quick by doing a self-review and by running impacted tests locally.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
API fails when omiting the 'load_balancing_scheme' field which is the expected behaviour according to the API docs in the references. So I am adding this flag to make it fail at the provider level.
I do not think this is a breaking change since all users are not able to actually create this resource without the 'load_balacing_scheme' field, but let me know if this not the case.
Hi there, I'm the Modular magician. I've detected the following information about your changes:
Diff report
Your PR generated some diffs in downstreams - here they are.
google provider: Diff ( 2 files changed, 16 insertions(+), 16 deletions(-))
google-beta provider: Diff ( 2 files changed, 16 insertions(+), 16 deletions(-))
Breaking Change(s) Detected
The following breaking change(s) were detected within your pull request.
- Field
load_balancing_schemechanged from optional to required ongoogle_network_services_lb_traffic_extension- reference
If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.
Tests analytics
Total tests: 51
Passed tests: 51
Skipped tests: 0
Affected tests: 0
Click here to see the affected service packages
- networkservices
$\textcolor{green}{\textsf{All tests passed!}}$ View the build log
This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.
Hello @BBBmau, could you get sometime to check this?
I'll need some confirmation on this in order to get this merged. I'll merge it once it's approved
This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.
This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.
This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.
This PR is approved and has been waiting for merge for 2 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.
This PR is approved and has been waiting for merge for 3 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.
This PR is approved and has been waiting for merge for 4 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.
This PR is approved and has been waiting for merge for 5 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.
This PR is approved and has been waiting for merge for 6 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.
This PR is approved and has been waiting for merge for 7 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.
This PR is approved and has been waiting for merge for 8 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.
This PR is approved and has been waiting for merge for 9 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.
This PR is approved and has been waiting for merge for 10 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.
This PR is approved and has been waiting for merge for 11 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.
Been meaning to get input on this. With this being marked as a breaking change would we include this into the 6.0.0 release @c2thorn ?
Been meaning to get input on this. With this being marked as a breaking change would we include this into the 6.0.0 release @c2thorn ?
There's not a lot of time left. This will need to be switched to the 6.0 feature branch and the upgrade guide entry needs to be added. See https://googlecloudplatform.github.io/magic-modules/develop/breaking-changes/make-a-breaking-change/#make-the-change-on-feature-branch-major-release-600
Additionally, the parent Github issue will need to be added to 6.0 milestone if this actually goes through.
This PR is approved and has been waiting for merge for 12 weeks. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.
This has missed the cutoff for 6.0, so I will close it to prevent it from accidentally getting merged into a minor release.